From: Thomas Huth <thuth@redhat.com>
To: Ard Biesheuvel <ardb+git@google.com>, linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH 2/7] x86/efi: Drop redundant EFI_PARAVIRT check
Date: Fri, 10 Apr 2026 13:36:33 +0200 [thread overview]
Message-ID: <665b4369-b322-477e-9ca1-2d83490a7c4b@redhat.com> (raw)
In-Reply-To: <20260410075950.1687350-11-ardb+git@google.com>
On 10/04/2026 09.59, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> efi_memblock_x86_reserve_range() exits early if EFI_PARAVIRT is set, so
> there is no point in checking it a second time further down.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/x86/platform/efi/efi.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index d84c6020dda1..b60f8454a1ec 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -211,11 +211,9 @@ int __init efi_memblock_x86_reserve_range(void)
> data.desc_size = e->efi_memdesc_size;
> data.desc_version = e->efi_memdesc_version;
>
> - if (!efi_enabled(EFI_PARAVIRT)) {
> - rv = efi_memmap_init_early(&data);
> - if (rv)
> - return rv;
> - }
> + rv = efi_memmap_init_early(&data);
> + if (rv)
> + return rv;
Maybe add:
Fixes: d85e3e3494078 ("efi: xen: Set EFI_PARAVIRT for Xen dom0 boot on all
architectures")
?
Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2026-04-10 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 7:59 [PATCH 0/7] x86/efi: Prepwork for memory map cleanup Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 1/7] x86/efi: Omit redundant kernel image overlap check Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 2/7] x86/efi: Drop redundant EFI_PARAVIRT check Ard Biesheuvel
2026-04-10 11:36 ` Thomas Huth [this message]
2026-04-10 7:59 ` [PATCH 3/7] x86/efi: Only merge EFI memory map entries on 32-bit systems Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 4/7] x86/efi: Defer sub-1M check from unmap to free stage Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 5/7] x86/efi: Simplify real mode trampoline allocation quirk Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 6/7] x86/efi: Unmap kernel-reserved boot regions from EFI page tables Ard Biesheuvel
2026-04-10 7:59 ` [PATCH 7/7] x86/efi: Drop EFI_MEMORY_RUNTIME check from __ioremap_check_other() Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=665b4369-b322-477e-9ca1-2d83490a7c4b@redhat.com \
--to=thuth@redhat.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox