From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-cxl@vger.kernel.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Terry Bowman <terry.bowman@amd.com>,
"Smita Koralahalli" <Smita.KoralahalliChannabasappa@amd.com>
Subject: Re: [PATCH v3 3/7] efi/cper, cxl: Remove cper_cxl.h
Date: Mon, 2 Dec 2024 12:15:03 -0600 [thread overview]
Message-ID: <674df927bf89_3cb8e029470@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20241119003915.174386-4-Smita.KoralahalliChannabasappa@amd.com>
Smita Koralahalli wrote:
> Move the declaration of cxl_cper_print_prot_err() to include/linux/cper.h
> to avoid maintaining a separate header file just for this function
> declaration. Remove drivers/firmware/efi/cper_cxl.h as its contents have
> been reorganized.
>
> Eliminate its corresponding #include directives from source files that
> previously included it, since the header file has been removed.
>
> No functional changes.
>
> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
I was going to make a comment on this header being pretty sparse after
patch 2. Thanks!
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
next prev parent reply other threads:[~2024-12-02 18:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 0:39 [PATCH v3 0/7] acpi/ghes, cper, cxl: Process CXL CPER Protocol errors Smita Koralahalli
2024-11-19 0:39 ` [PATCH v3 1/7] efi/cper, cxl: Prefix protocol error struct and function names with cxl_ Smita Koralahalli
2024-11-26 15:05 ` Jonathan Cameron
2024-12-02 18:12 ` Ira Weiny
2024-11-19 0:39 ` [PATCH v3 2/7] efi/cper, cxl: Make definitions and structures global Smita Koralahalli
2024-11-26 15:09 ` Jonathan Cameron
2024-12-02 18:15 ` Ira Weiny
2024-11-19 0:39 ` [PATCH v3 3/7] efi/cper, cxl: Remove cper_cxl.h Smita Koralahalli
2024-11-26 15:51 ` Jonathan Cameron
2024-11-27 19:36 ` Smita Koralahalli
2024-12-02 18:15 ` Ira Weiny [this message]
2024-11-19 0:39 ` [PATCH v3 4/7] acpi/ghes, cxl: Rename cxl_cper_register_work to cxl_cper_register_event_work Smita Koralahalli
2024-11-26 15:53 ` Jonathan Cameron
2024-11-19 0:39 ` [PATCH v3 5/7] acpi/ghes, cxl: Refactor work registration functions to support multiple workqueues Smita Koralahalli
2024-11-26 15:57 ` Jonathan Cameron
2024-11-27 19:46 ` Smita Koralahalli
2024-11-19 0:39 ` [PATCH v3 6/7] acpi/ghes, cper: Recognize and cache CXL Protocol errors Smita Koralahalli
2024-11-26 16:05 ` Jonathan Cameron
2024-12-02 18:41 ` Ira Weiny
2024-12-06 16:16 ` Koralahalli Channabasappa, Smita
2024-11-19 0:39 ` [PATCH v3 7/7] acpi/ghes, cxl/pci: Process CXL CPER Protocol Errors Smita Koralahalli
2024-11-26 16:05 ` Jonathan Cameron
2024-11-27 20:35 ` Smita Koralahalli
2024-12-02 18:48 ` Ira Weiny
2024-12-06 16:29 ` Koralahalli Channabasappa, Smita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=674df927bf89_3cb8e029470@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox