From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Thorsten Blum" <thorsten.blum@linux.dev>, "Jeremy Kerr" <jk@ozlabs.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efivarfs: use QSTR() in efivarfs_alloc_dentry
Date: Thu, 23 Apr 2026 17:42:11 +0200 [thread overview]
Message-ID: <7a5f145c-9094-426b-9fa2-79c853cb04f1@app.fastmail.com> (raw)
In-Reply-To: <20260422122525.99460-3-thorsten.blum@linux.dev>
Hi Thorsten,
On Wed, 22 Apr 2026, at 14:25, Thorsten Blum wrote:
> Use QSTR() and drop strlen() in efivarfs_alloc_dentry().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/efivarfs/super.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
I'll queue this up once -rc1 comes around. Thanks.
> diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c
> index 1c5224cf183e..95a685f022e6 100644
> --- a/fs/efivarfs/super.c
> +++ b/fs/efivarfs/super.c
> @@ -192,12 +192,9 @@ static const struct dentry_operations efivarfs_d_ops = {
> static struct dentry *efivarfs_alloc_dentry(struct dentry *parent, char *name)
> {
> struct dentry *d;
> - struct qstr q;
> + struct qstr q = QSTR(name);
> int err;
>
> - q.name = name;
> - q.len = strlen(name);
> -
> err = efivarfs_d_hash(parent, &q);
> if (err)
> return ERR_PTR(err);
next prev parent reply other threads:[~2026-04-23 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:25 [PATCH] efivarfs: use QSTR() in efivarfs_alloc_dentry Thorsten Blum
2026-04-23 15:42 ` Ard Biesheuvel [this message]
2026-04-25 3:08 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a5f145c-9094-426b-9fa2-79c853cb04f1@app.fastmail.com \
--to=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox