From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C359213E74 for ; Fri, 28 Mar 2025 09:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743154193; cv=none; b=SkqOXOWo/ktzCnxTug3GuigDDraRnk6lvjiIkocwEWzv91AU6acXNxHK0PMy4XQR2mfLrST9nHd2421/UyLQAtqGEaGhefwbFekqZxp6Ql12nB+MfH23bm8T+xFX37O/c4o0LNcY2VwEMwFv0YC8f0CxPJWp1i5I6y8gD+E/kP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743154193; c=relaxed/simple; bh=YFPp9WWr4Tv2T63WZi3Pvgti8ml4lgh5//Cy6S6Rb+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z8YzTtdsxVXwHcSoSFlC7lCsa07Hko9EyuU6xVOv0p7DQuH764gs2iLhHQb5hxxKnGc/4u8LWoUZOMfTccczawaHUBXn9xJ3O4MMuXtwq6PeBOofQM0dobMIwwalTmyJ3mFN8lSrXCj18+JNMl6mQCkjGMMpzt9c2CFprkWB+cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=sU4xkTDc; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="sU4xkTDc" Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 9105B419F2 for ; Fri, 28 Mar 2025 09:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1743154181; bh=W0DQXE4Sz8iAfts0R9aUVRwmGkJey3qq2CZOpEhXzA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sU4xkTDcfTW8JHeMxU1BfmxHlnvndchLBEuRffGwYH0LBy4Flx5HpayNtyRGO51SZ DeryvzcM+0VjzClKS9X8kMsA6zJITV7tlnqwHpJ8QhPHDqwDeoHB4L3HlisJ5Mcbqv orZWuHMddxEYvQmIxemeTcmfqFwMOb/vUFWXRvwrLNMfp9a+vMDdoBHkmOlhp09ZGN DRSQlV1BthX6H4auPqR5RUflB+RCRYF+Op8B/iuR5ao5+C4Giqk228aHD813aTZQ09 Skp4Luf7NQyHELuBsgnloYwP2BgfF+JLmlCnNE4JjEZiV9tQ8LcnaRaWVQ+EB71nuf r+EXqi/O2sJlw== Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d0a037f97so10978455e9.2 for ; Fri, 28 Mar 2025 02:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743154180; x=1743758980; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W0DQXE4Sz8iAfts0R9aUVRwmGkJey3qq2CZOpEhXzA0=; b=T0z89EVtIoSY7pBiIkMMdCcPcSHYmS9QxK/Bnv7+2MvOxVIFcIdV28UrTchEdXl5hi FMl7vN8amSsuO8XgO6CBX1/arFFfK33Y1BylxtgIh51bHEVvpASTKgKhL1U+yAXUfBi+ 5+Tf5BW7pCHMeZYMVJ9cJg6yBVChs/059PFD/42F5sIfyxUd54PNYunzi6cK5pTm6jLQ xg3IzZb7tkbiKxSqg91cgLoDFyEIEeJtIJhKq5HeLVkQhDUBsQ1XC58cIHzE34Uh62Nz rLDbrGxomnvvpCjaitV5YpjqFk3GQu6OWEWrIh6PaKlZTZtfBZS1fjQVjmZKZzOoYt4D NcUw== X-Gm-Message-State: AOJu0YzxIrGqcHzfsUb9H/k+LUf3WMmRTqnMT4pUBF/kYq6KeoYddbZY 53sIpWz7nJtXsNRvHSJcWKaKXLGNF9lV4vmMInzRMWPobLowsgsXvkBv9v5QZiuBuQq27iKvhuu oWdpUC/nvwcyHBT4d7xg4xpF1ohIoGe/H2utXzmfKHFpvebZXNCN8uCK5AeQZGujNSvzC+3MQPA == X-Gm-Gg: ASbGncuyBVs2su5EC2Fv97ek2BQtj7losOpXD+iC4yFDXX1inSWZA5QyCE+2Egiil4l K+DGJpYFfHcDu50RpYRcWvzo9zLTYYxh3boS4Ob1QLhKfnFA7iBKsRc4Vc/n3nuci2ihEXvB9Sh HPwnh3wxv58OXE5DBlDGVTwj/pGszrQ+1tsT8AzzAVsXA/P+CQKBlu+Yzeip71YXsKEm7Qnxoi5 g/WcMA6bsC7eEI2O+VDEsTVzNiD1u7vFl35rLaLEQH8djZtKQrUzwfpDhD9daa791rDOVRX1iIP JLnoslZC0I14dwngjplqRPH6n37Dfm7/Q6IGd2DJC056wHivvesO1mu5U7V6JA== X-Received: by 2002:a05:600c:6a13:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-43d8522cc96mr65306195e9.11.1743154179923; Fri, 28 Mar 2025 02:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRHH6+C7f9WxPlfoclpQ4muAxjcE3H0jmeXlyq7TyVvgI6TU6FiLwynF58/TpV7N3SAbOGGQ== X-Received: by 2002:a05:600c:6a13:b0:43b:ce36:7574 with SMTP id 5b1f17b1804b1-43d8522cc96mr65305975e9.11.1743154179563; Fri, 28 Mar 2025 02:29:39 -0700 (PDT) Received: from [192.168.80.20] (51.169.30.93.rev.sfr.net. [93.30.169.51]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff02f9csm21538575e9.26.2025.03.28.02.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Mar 2025 02:29:39 -0700 (PDT) Message-ID: <7afc3a7e-1dd8-4dbb-b243-75bd554c00da@canonical.com> Date: Fri, 28 Mar 2025 10:29:38 +0100 Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] block: fix conversion of GPT partition name to 7-bit To: Ben Hutchings , Ming Lei , Jens Axboe , linux-block@vger.kernel.org Cc: linux-efi@vger.kernel.org, Mulhern , Davidlohr Bueso , stable@vger.kernel.org References: <20250305022154.3903128-1-ming.lei@redhat.com> <3fa05bba190bec01df2bc117cf7e3e2f00e8b946.camel@decadent.org.uk> Content-Language: en-US From: Olivier Gayot In-Reply-To: <3fa05bba190bec01df2bc117cf7e3e2f00e8b946.camel@decadent.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > We shouldn't mask the input character; instead we should do a range > check before calling isprint(). Something like: > > u16 uc = le16_to_cpu(in[i]); > u8 c; > > if (uc < 0x80 && (uc == 0 || isprint(uc))) > c = uc; > else > c = '!'; Sounds like a good alternative to me. Would a conversion from utf-16-le to utf-8 be a viable solution?