public inbox for linux-efi@vger.kernel.org
 help / color / mirror / Atom feed
From: Madper Xie <cxie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
Cc: Toshi Kani <toshi.kani-VXdhtT5mjnY@public.gmane.org>,
	Madper Xie <cxie-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Matt Fleming
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-kernel@vger.kernel.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-efi@vger.kernel.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>,
	"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
	Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
Subject: Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003
Date: Thu, 13 Feb 2014 21:40:36 +0800	[thread overview]
Message-ID: <87k3czdtbf.fsf@redhat.com> (raw)
In-Reply-To: <20140213105547.GC20717-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>


matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org writes:

> On Wed, 12 Feb, at 09:15:03AM, Toshi Kani wrote:
>> 
>> Hi Matt,
>> 
>> Yes, I agree that the table size should be 0x38.  However, ACPI spec
>> states that bit0 of status indicates if the boot image graphic is valid.
>> This bit is set to 0 (invalid) on the system.  Can you check this bit
>> and return when invalid? 
>
> Madper, could you try out this patch?
>
Thanks Matt. This patch fix the panic. And ioremap warning disappeared
after apply your patch.
> ---
>
> diff --git a/arch/x86/platform/efi/efi-bgrt.c b/arch/x86/platform/efi/efi-bgrt.c
> index 4df9591eadad..f15103dff4b4 100644
> --- a/arch/x86/platform/efi/efi-bgrt.c
> +++ b/arch/x86/platform/efi/efi-bgrt.c
> @@ -42,7 +42,7 @@ void __init efi_bgrt_init(void)
>  
>  	if (bgrt_tab->header.length < sizeof(*bgrt_tab))
>  		return;
> -	if (bgrt_tab->version != 1)
> +	if (bgrt_tab->version != 1 || bgrt_tab->status != 1)
>  		return;
>  	if (bgrt_tab->image_type != 0 || !bgrt_tab->image_address)
>  		return;

-- 
Madper

  parent reply	other threads:[~2014-02-13 13:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10  7:23 [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003 Madper Xie
2014-02-10 17:52 ` Matt Fleming
     [not found]   ` <20140210175246.GB2887-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-02-11  3:00     ` Madper Xie
     [not found]       ` <87mwhy8iaj.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-11 13:16         ` Matt Fleming
2014-02-11 13:47           ` Madper Xie
     [not found]             ` <87lhxh69u0.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-11 14:18               ` Matt Fleming
2014-02-12  0:00                 ` Rafael J. Wysocki
     [not found]                 ` <20140211141846.GA1725-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-02-12 16:15                   ` Toshi Kani
     [not found]                     ` <1392221703.5612.164.camel-RbGIw1UOYPVo/CpIj0byZw@public.gmane.org>
2014-02-12 16:39                       ` Matt Fleming
2014-02-13 10:55                     ` Matt Fleming
     [not found]                       ` <20140213105547.GC20717-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-02-13 13:40                         ` Madper Xie [this message]
     [not found]                           ` <87k3czdtbf.fsf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-13 17:10                             ` Matthew Garrett
2014-02-13 23:48                               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3czdtbf.fsf@redhat.com \
    --to=cxie-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org \
    --cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
    --cc=toshi.kani-VXdhtT5mjnY@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox