From mboxrd@z Thu Jan 1 00:00:00 1970 From: Madper Xie Subject: Re: [PATCH v2] efi-pstore: Make efi-pstore return a unique id Date: Thu, 28 Nov 2013 10:15:18 +0800 Message-ID: <87vbzdb7bd.fsf@redhat.com> References: <87bo1bnxhi.fsf@redhat.com> <20131127114440.GF18170@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-reply-to: <20131127114440.GF18170-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Madper Xie , "'linux-kernel@vger.kernel.org'" , "linux-efi@vger.kernel.org" , "matt.fleming@intel.com" , Seiji Aguchi , "richard@nod.at" , Tony Luck List-Id: linux-efi@vger.kernel.org matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org writes: > On Sat, 23 Nov, at 07:55:37PM, Madper Xie wrote: >> >> Pstore fs expects that backends provide a uniqued id which could avoid >> pstore making entries as duplication or denominating entries the same >> name. So I combine the timestamp, part and count into id. >> >> Signed-off-by: Madper Xie >> --- >> drivers/firmware/efi/efi-pstore.c | 19 +++++++++++++------ >> 1 file changed, 13 insertions(+), 6 deletions(-) > > Thanks unless anyone complains, I'm going to apply this. > > Does this need to be tagged for stable? Since it fix a real issue, my answer is "Yes".