Re: [PATCH v2 1/3] firmware/sysfb: Remove rotation quirk for Lenovo D330

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 31.08.26 um 14:49 schrieb Jani Nikula:
> On Mon, 31 Aug 2026, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> The Lenovo D330 is a notebook with unmountable display. The display
> Please elaborate on what you mean by "unmountable display".
>
> No comments on the patch itself, I just haven't heard that before.

Sorry, that word doesn't exist; maybe "mountable".  I think "detachable" 
is the correct word.  The notebook's display can be removed from the 
keyboard to act like a tablet.

Best regards
Thomas

>
>> is installed in landscape orientation, but the display mode is in
>> portrait orientation. By default, the display output is rotated to
>> the left by 90°.
>>
>> The sysfb quirk breaks the display by swapping display width and
>> height; and thus mixing up the display geometry. Fix this by keeping
>> the display as-is. The sysfb DRM drivers, usually efidrm, will pick
>> the correct panel orientation for the display.
>>
>> Tested on a Lenovo D330-10IGM IdeaPad.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>> ---
>>   drivers/firmware/efi/sysfb_efi.c | 9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
>> index 685283bb7327..2338de73c62c 100644
>> --- a/drivers/firmware/efi/sysfb_efi.c
>> +++ b/drivers/firmware/efi/sysfb_efi.c
>> @@ -301,15 +301,6 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>>   		},
>>   		.callback = efifb_swap_width_height,
>>   	},
>> -	{
>> -		/* Lenovo D330 with 800x1280 or 1200x1920 portrait screen */
>> -		.matches = {
>> -			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> -			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
>> -					"Lenovo ideapad D330-10IGM"),
>> -		},
>> -		.callback = efifb_swap_width_height,
>> -	},
>>   	{
>>   		/*
>>   		 * Lenovo IdeaPad Duet 3 10IGL5 and 10IGL5-LTE with

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)