From: Kees Cook <kees@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>, linux-efi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lkdtm: Add more EFI runtime tests
Date: Mon, 12 Oct 2026 10:07:53 -0700 [thread overview]
Message-ID: <90ACF5FB-44A7-4869-A770-E7A30FEAFBC2@kernel.org> (raw)
In-Reply-To: <20261011114013.1130-2-ardb@kernel.org>
On October 11, 2026 4:40:14 AM PDT, Ard Biesheuvel <ardb@kernel.org> wrote:
>+static void efi_rt_test(enum efi_rts_ids id, const char *desc)
>+{
>+ efi_status_t status = efi.lkdtm_rt_test(id);
>+
>+ if (status == EFI_UNSUPPORTED)
>+ pr_err("XFAIL: Test not supported on this configuration\n");
I've tried to have more specific rationale for XFAIL reports. Like, I try to say what someone needs to do to make it not an XFAIL. Here that's running under EFI?
Otherwise looks good! If that message is made a little more "actionable", feel free to take via EFI:
Reviewed-by: Kees Cook <kees@kernel.org>
-Kees
--
Kees Cook
next prev parent reply other threads:[~2026-10-12 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 11:40 [PATCH] lkdtm: Add more EFI runtime tests Ard Biesheuvel
2026-10-12 17:07 ` Kees Cook [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-10-11 14:48 MaeeFilho FL
2026-10-12 5:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ACF5FB-44A7-4869-A770-E7A30FEAFBC2@kernel.org \
--to=kees@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox