Re: [PATCH v2 2/2] efi: arm-stub: Round up FDT allocation to mapping size

Ard Biesheuvel
2017-03-20T23:40:35Z

On 20 March 2017 at 23:25, Timur Tabi <timur@codeaurora.org> wrote:
> On Thu, Feb 9, 2017 at 3:42 PM, Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
>> The FDT is mapped via a fixmap entry that is at least 2 MB in size and
>> 2 MB aligned on 4 KB page size kernels.
>>
>> On UEFI systems, the FDT allocation may share this 2 MB block with a
>> reserved region, or another memory region that we should never map,
>> unless we account for this in the size of the allocation (the alignment
>> is already 2 MB)
>>
>> So instead of taking guesses at the needed space, simply allocate 2 MB
>> immediately. The allocation will be recorded as a EFI_LOADER_DATA, and
>> the kernel only memblock_reserve()'s the actual size of the FDT, so the
>> unused space will be released to the kernel.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> This patch is over a month old, and it's been reviewed and tested. We
> really need this in 4.11. Please get this merged into 4.11-rc4.
>

We never queue non-critical changes right before the merge window
opens, so it was queued for v4.12 instead.

If it is so important that this ends up in v4.11, you should have
mentioned this at the time, or over the course of the past four weeks.