From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roy Franz Subject: Re: [PATCH 06/22] Add helper functions used by arm/arm64 Date: Fri, 14 Feb 2014 11:02:49 -0800 Message-ID: References: <1391619853-10601-1-git-send-email-leif.lindholm@linaro.org> <1391619853-10601-7-git-send-email-leif.lindholm@linaro.org> <20140213112606.GF20717@console-pimps.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140213112606.GF20717-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Leif Lindholm , Linux Kernel Mailing List , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Patch Tracking List-Id: linux-efi@vger.kernel.org On Thu, Feb 13, 2014 at 3:26 AM, Matt Fleming wrote: > On Wed, 05 Feb, at 05:03:57PM, Leif Lindholm wrote: >> From: Roy Franz >> >> Add the get_dram_base() function and efi_call_physN() macros >> that are shared by arm/arm64. >> >> Signed-off-by: Roy Franz >> Signed-off-by: Leif Lindholm >> --- >> drivers/firmware/efi/efi-stub-helper.c | 63 +++++++++++++++++++++++++------- >> 1 file changed, 50 insertions(+), 13 deletions(-) > > These changes should be in drivers/firmware/efi/arm-stub.c - > efi-stub-helper.c is not a dumping ground for random > architecture-specific code. Hi Matt, I will move those functions/macros to the arm-stub.c file. I agree that the macros should go there, as they are the arm specific versions and conflict with the x86 versions defined elsewhere. These were there before the arm-stub.c file was added and didn't get moved when it was. The get_dram_base() function is only used by arm/arm64, but there is nothing architecture specific about it, which is why I put it here to begin with. I don't feel strongly about this either way. Thanks, Roy > > -- > Matt Fleming, Intel Open Source Technology Center