From: Ard Biesheuvel <ardb@kernel.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Akihiko Odaki <akihiko.odaki@gmail.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-efi@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
Date: Tue, 5 Apr 2022 20:00:41 +0200 [thread overview]
Message-ID: <CAMj1kXGHQm7yy2QPCEVRiXBzb8HWOHzKMCuoS+mbnBKujEXQnA@mail.gmail.com> (raw)
In-Reply-To: <87bkxfebsu.fsf@meer.lwn.net>
On Tue, 5 Apr 2022 at 18:26, Jonathan Corbet <corbet@lwn.net> wrote:
>
> Akihiko Odaki <akihiko.odaki@gmail.com> writes:
>
> > x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
> > Convert x86 EFI earlyprintk into generic earlycon implementation").
>
> So I will confess that I don't know this area well enough to know
> whether this patch makes sense or not. To help with that, it would have
> been good to CC Ard, who is the author of the patch you cite above.
> Adding him now.
>
> Ard, do you agree with this change (preserved below)?
>
Yes, it looks fine to me.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index f5a27f067db9..fb39337f4123 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -1252,7 +1252,7 @@
> > Append ",keep" to not disable it when the real console
> > takes over.
> >
> > - Only one of vga, efi, serial, or usb debug port can
> > + Only one of vga, serial, or usb debug port can
> > be used at a time.
> >
> > Currently only ttyS0 and ttyS1 may be specified by
> > @@ -1267,7 +1267,7 @@
> > Interaction with the standard serial driver is not
> > very good.
> >
> > - The VGA and EFI output is eventually overwritten by
> > + The VGA output is eventually overwritten by
> > the real console.
> >
> > The xen option can only be used in Xen domains.
> > --
> > 2.35.1
next prev parent reply other threads:[~2022-04-06 4:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 4:58 [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation Akihiko Odaki
2022-04-05 16:26 ` Jonathan Corbet
2022-04-05 18:00 ` Ard Biesheuvel [this message]
2022-04-16 8:48 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGHQm7yy2QPCEVRiXBzb8HWOHzKMCuoS+mbnBKujEXQnA@mail.gmail.com \
--to=ardb@kernel.org \
--cc=akihiko.odaki@gmail.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).