* [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
@ 2022-03-21 4:58 Akihiko Odaki
2022-04-05 16:26 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Akihiko Odaki @ 2022-03-21 4:58 UTC (permalink / raw)
Cc: linux-kernel, linux-doc, linux-efi, x86, Jonathan Corbet,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H . Peter Anvin, Akihiko Odaki
x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
Convert x86 EFI earlyprintk into generic earlycon implementation").
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
Documentation/admin-guide/kernel-parameters.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index f5a27f067db9..fb39337f4123 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1252,7 +1252,7 @@
Append ",keep" to not disable it when the real console
takes over.
- Only one of vga, efi, serial, or usb debug port can
+ Only one of vga, serial, or usb debug port can
be used at a time.
Currently only ttyS0 and ttyS1 may be specified by
@@ -1267,7 +1267,7 @@
Interaction with the standard serial driver is not
very good.
- The VGA and EFI output is eventually overwritten by
+ The VGA output is eventually overwritten by
the real console.
The xen option can only be used in Xen domains.
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
2022-03-21 4:58 [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation Akihiko Odaki
@ 2022-04-05 16:26 ` Jonathan Corbet
2022-04-05 18:00 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2022-04-05 16:26 UTC (permalink / raw)
To: Akihiko Odaki
Cc: linux-kernel, linux-doc, linux-efi, x86, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H . Peter Anvin,
Akihiko Odaki, Ard Biesheuvel
Akihiko Odaki <akihiko.odaki@gmail.com> writes:
> x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
> Convert x86 EFI earlyprintk into generic earlycon implementation").
So I will confess that I don't know this area well enough to know
whether this patch makes sense or not. To help with that, it would have
been good to CC Ard, who is the author of the patch you cite above.
Adding him now.
Ard, do you agree with this change (preserved below)?
Thanks,
jon
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index f5a27f067db9..fb39337f4123 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1252,7 +1252,7 @@
> Append ",keep" to not disable it when the real console
> takes over.
>
> - Only one of vga, efi, serial, or usb debug port can
> + Only one of vga, serial, or usb debug port can
> be used at a time.
>
> Currently only ttyS0 and ttyS1 may be specified by
> @@ -1267,7 +1267,7 @@
> Interaction with the standard serial driver is not
> very good.
>
> - The VGA and EFI output is eventually overwritten by
> + The VGA output is eventually overwritten by
> the real console.
>
> The xen option can only be used in Xen domains.
> --
> 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
2022-04-05 16:26 ` Jonathan Corbet
@ 2022-04-05 18:00 ` Ard Biesheuvel
2022-04-16 8:48 ` Jonathan Corbet
0 siblings, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2022-04-05 18:00 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Akihiko Odaki, linux-kernel, linux-doc, linux-efi, x86,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H . Peter Anvin
On Tue, 5 Apr 2022 at 18:26, Jonathan Corbet <corbet@lwn.net> wrote:
>
> Akihiko Odaki <akihiko.odaki@gmail.com> writes:
>
> > x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
> > Convert x86 EFI earlyprintk into generic earlycon implementation").
>
> So I will confess that I don't know this area well enough to know
> whether this patch makes sense or not. To help with that, it would have
> been good to CC Ard, who is the author of the patch you cite above.
> Adding him now.
>
> Ard, do you agree with this change (preserved below)?
>
Yes, it looks fine to me.
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index f5a27f067db9..fb39337f4123 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -1252,7 +1252,7 @@
> > Append ",keep" to not disable it when the real console
> > takes over.
> >
> > - Only one of vga, efi, serial, or usb debug port can
> > + Only one of vga, serial, or usb debug port can
> > be used at a time.
> >
> > Currently only ttyS0 and ttyS1 may be specified by
> > @@ -1267,7 +1267,7 @@
> > Interaction with the standard serial driver is not
> > very good.
> >
> > - The VGA and EFI output is eventually overwritten by
> > + The VGA output is eventually overwritten by
> > the real console.
> >
> > The xen option can only be used in Xen domains.
> > --
> > 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
2022-04-05 18:00 ` Ard Biesheuvel
@ 2022-04-16 8:48 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2022-04-16 8:48 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Akihiko Odaki, linux-kernel, linux-doc, linux-efi, x86,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H . Peter Anvin
Ard Biesheuvel <ardb@kernel.org> writes:
> On Tue, 5 Apr 2022 at 18:26, Jonathan Corbet <corbet@lwn.net> wrote:
>>
>> Akihiko Odaki <akihiko.odaki@gmail.com> writes:
>>
>> > x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
>> > Convert x86 EFI earlyprintk into generic earlycon implementation").
>>
>> So I will confess that I don't know this area well enough to know
>> whether this patch makes sense or not. To help with that, it would have
>> been good to CC Ard, who is the author of the patch you cite above.
>> Adding him now.
>>
>> Ard, do you agree with this change (preserved below)?
>>
>
> Yes, it looks fine to me.
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Great. Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-16 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-21 4:58 [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation Akihiko Odaki
2022-04-05 16:26 ` Jonathan Corbet
2022-04-05 18:00 ` Ard Biesheuvel
2022-04-16 8:48 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).