Linux EFI development
 help / color / mirror / Atom feed
From: "Kani, Toshi" <toshi.kani@hpe.com>
To: Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
	James Morse <james.morse@arm.com>,
	Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Robert Richter <rric@kernel.org>,
	Robert Moore <robert.moore@intel.com>,
	Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Jan Luebbe <jlu@pengutronix.de>,
	Khuong Dinh <khuong@os.amperecomputing.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"devel@acpica.org" <devel@acpica.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Shuai Xue <xueshuai@linux.alibaba.com>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH v4 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes module parameter
Date: Fri, 2 Sep 2022 14:54:25 +0000	[thread overview]
Message-ID: <DM4PR84MB18539F451E3C89DA2853539B827A9@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220831074027.13849-4-justin.he@arm.com>

On Wednesday, August 31, 2022 1:40 AM, Jia He wrote:
> +/*
> + * "ghes.edac_force_load" forcibly loads ghes_edac and skips the platform
> + * check.
> + */
> +bool ghes_edac_force_load;
> +module_param_named(edac_force_load, ghes_edac_force_load, bool, 0);
> +EXPORT_SYMBOL(ghes_edac_force_load);

Since ghes has no ability to load ghes_edac module, I suggest changing
the option name to ghes.edac_force_enable or ghes.edac_enable.

Toshi

  reply	other threads:[~2022-09-02 15:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31  7:40 [PATCH v4 0/8] Make ghes_edac a proper module Jia He
2022-08-31  7:40 ` [PATCH v4 1/8] efi/cper: export several helpers for ghes_edac to use Jia He
2022-08-31  7:40 ` [PATCH v4 2/8] EDAC/ghes: Add a notifier for reporting memory errors Jia He
2022-08-31  7:40 ` [PATCH v4 3/8] EDAC:ghes: Move ghes_edac.force_load to ghes module parameter Jia He
2022-09-02 14:54   ` Kani, Toshi [this message]
2022-08-31  7:40 ` [PATCH v4 4/8] ghes: Introduce a helper ghes_edac_preferred() Jia He
2022-09-02 15:30   ` Kani, Toshi
2022-08-31  7:40 ` [PATCH v4 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes Jia He
2022-09-02 17:13   ` Kani, Toshi
2022-09-05 14:33     ` Justin He
2022-08-31  7:40 ` [PATCH v4 6/8] EDAC: Add the ghes_edac_preferred check for chipset-specific edac drivers Jia He
2022-09-02 15:48   ` Kani, Toshi
2022-08-31  7:40 ` [PATCH v4 7/8] apei/ghes: Use unrcu_pointer for cmpxchg Jia He
2022-08-31  7:40 ` [PATCH v4 8/8] EDAC/igen6: Return consistent errno when another edac driver is enabled Jia He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR84MB18539F451E3C89DA2853539B827A9@DM4PR84MB1853.NAMPRD84.PROD.OUTLOOK.COM \
    --to=toshi.kani@hpe.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=devel@acpica.org \
    --cc=james.morse@arm.com \
    --cc=jarkko@kernel.org \
    --cc=jlu@pengutronix.de \
    --cc=justin.he@arm.com \
    --cc=khuong@os.amperecomputing.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nd@arm.com \
    --cc=qiuxu.zhuo@intel.com \
    --cc=rafael@kernel.org \
    --cc=robert.moore@intel.com \
    --cc=rric@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=xueshuai@linux.alibaba.com \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox