From: Jarkko Sakkinen <jarkko@kernel.org>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Matthew Garrett <mjg59@google.com>,
Bartosz Szczepanek <bsz@semihalf.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] efi/tpm: Pass correct address to memblock_reserve
Date: Mon, 24 Oct 2022 00:59:10 +0300 [thread overview]
Message-ID: <Y1W5LlI/fRo6XhU9@kernel.org> (raw)
In-Reply-To: <20221022152352.1033750-1-jsnitsel@redhat.com>
On Sat, Oct 22, 2022 at 08:23:52AM -0700, Jerry Snitselaar wrote:
> memblock_reserve() expects a physical address, but the address being
> passed for the TPM final events log is what was returned from
> early_memremap(). This results in something like the following:
>
> [ 0.000000] memblock_reserve: [0xffffffffff2c0000-0xffffffffff2c00e4] efi_tpm_eventlog_init+0x324/0x370
>
> Pass the address from efi like what is done for the TPM events log.
>
> Fixes: c46f3405692d ("tpm: Reserve the TPM final events table")
> Cc: Matthew Garrett <mjg59@google.com>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Bartosz Szczepanek <bsz@semihalf.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
> ---
> drivers/firmware/efi/tpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
> index 8f665678e9e3..e8d69bd548f3 100644
> --- a/drivers/firmware/efi/tpm.c
> +++ b/drivers/firmware/efi/tpm.c
> @@ -97,7 +97,7 @@ int __init efi_tpm_eventlog_init(void)
> goto out_calc;
> }
>
> - memblock_reserve((unsigned long)final_tbl,
> + memblock_reserve(efi.tpm_final_log,
> tbl_size + sizeof(*final_tbl));
> efi_tpm_final_log_size = tbl_size;
>
> --
> 2.37.2
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2022-10-23 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 15:23 [PATCH] efi/tpm: Pass correct address to memblock_reserve Jerry Snitselaar
2022-10-23 21:59 ` Jarkko Sakkinen [this message]
2022-10-24 6:04 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1W5LlI/fRo6XhU9@kernel.org \
--to=jarkko@kernel.org \
--cc=ardb@kernel.org \
--cc=bsz@semihalf.com \
--cc=jsnitsel@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox