From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B533CC25B4E for ; Fri, 20 Jan 2023 16:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbjATQEb (ORCPT ); Fri, 20 Jan 2023 11:04:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbjATQEa (ORCPT ); Fri, 20 Jan 2023 11:04:30 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4294737F29; Fri, 20 Jan 2023 08:04:30 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFCE461FD8; Fri, 20 Jan 2023 16:04:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13B2DC433D2; Fri, 20 Jan 2023 16:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674230669; bh=Ec4H1FXPr6bovVxs4vc810kRh1msVN4iB85TbOfb4ec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rEoxzo6adt5Ed6rCJIuoSySpq1ZPl7v5+teYwR3RfNP/H7oyumltXJUdDjvJia+m0 G4DTKete4ggG3ww2DJ5vcFJDTO+TfYdcX/3iybFNBuVkOg+FcIX/lM32qmwd1HZtMB o4BV1i2VJOAUkzB+n62e5zfYY92PX9ZY+fNjwuoxWujAVyBsWlY7wt8slGtJ15kz37 5xVBfgXNpKR3CUT8Egin490uUkm2luvme5s3oEUg4vkuyZXjEpy6bADaCpe/7GIBc1 TuiR9dB3uVGDEgEzTd7Jgr4HqAcdgRS11fH9amLTjabQP/MXwAbecIVJk4Abv1EHMC BHIhzYlMokYLQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pItsx-0008Ih-TV; Fri, 20 Jan 2023 17:04:59 +0100 Date: Fri, 20 Jan 2023 17:04:59 +0100 From: Johan Hovold To: Ard Biesheuvel Cc: Johan Hovold , Peter Jones , Heinrich Schuchardt , Matthew Garrett , Jeremy Kerr , Maximilian Luz , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] efivarfs: always register filesystem Message-ID: References: <20230119164255.28091-1-johan+linaro@kernel.org> <20230119164255.28091-3-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, Jan 20, 2023 at 10:23:18AM +0100, Ard Biesheuvel wrote: > (cc Peter, Heinrich) > > On Thu, 19 Jan 2023 at 17:45, Johan Hovold wrote: > > > > The efivar ops are typically registered at subsys init time so that > > they are available when efivarfs is registered at module init time. > > > > Other efivars implementations, such as Google SMI, exists and can > > currently be build as modules which means that efivar may not be > > available when efivarfs is initialised. > > > > Move the efivar availability check from module init to when the > > filesystem is mounted to allow late registration of efivars. > > > > Signed-off-by: Johan Hovold > > I think this change is fine in principle, but I 'm not sure if there > is user space code that the distros are carrying that might get > confused by this: beforehand, efivarfs would not exist in > /proc/filesystems and now, it will but trying to mount it might fail. User space must already handle mount failing since commit 483028edacab ("efivars: respect EFI_UNSUPPORTED return from firmware") so that should not be an issue. Johan