From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C86C433F5 for ; Fri, 4 Mar 2022 07:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238916AbiCDHoX (ORCPT ); Fri, 4 Mar 2022 02:44:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238876AbiCDHoW (ORCPT ); Fri, 4 Mar 2022 02:44:22 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32989192E08; Thu, 3 Mar 2022 23:43:31 -0800 (PST) Received: from nazgul.tnic (dynamic-002-247-254-208.2.247.pool.telefonica.de [2.247.254.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 75F971EC01CE; Fri, 4 Mar 2022 08:43:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1646379805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wa4qlj2kScoKOUQ36KYA3lgsrDq7guOB8fZmS8g/Qg8=; b=IW0oc0svgti4hQijwpuUIret1pQsGi4VDbH4SBbOxVTSDeLfDBgYrDnLtxYouaWlH+vc4P OVDvTnOraR9H80HGMhLDNW1vLwDMRLLK8EZQ4QImSQvm6Oe4coXv0qK8SyeGDBigoVmH7T GL6AOJQC1jqI/1RfuGCkgL1TVy2JrRQ= Date: Fri, 4 Mar 2022 08:43:30 +0100 From: Borislav Petkov To: Michael Roth Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v11 39/45] x86/sev: Use firmware-validated CPUID for SEV-SNP guests Message-ID: References: <20220224165625.2175020-1-brijesh.singh@amd.com> <20220224165625.2175020-40-brijesh.singh@amd.com> <20220304003157.diqytybw6gpwn5sa@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220304003157.diqytybw6gpwn5sa@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Thu, Mar 03, 2022 at 06:31:57PM -0600, Michael Roth wrote: > In that case it seems to expect "mce=option1 mce=option2" etc. I could > open-code a parser to handle multiple options like sev=option1,option2 > etc., but wanted to check with you first. Yap, that would make most sense - you want to be able to enable a couple of options without excessive typing. > Also, should I go ahead and introduce struct sev_options now, or > just use a regular bool until more options are added later? struct sev_config { __u64 debug : 1, __reserved : 63; } just like struct mca_config. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette