From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B119AC433F5 for ; Thu, 28 Apr 2022 10:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236404AbiD1KMK (ORCPT ); Thu, 28 Apr 2022 06:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234245AbiD1KLp (ORCPT ); Thu, 28 Apr 2022 06:11:45 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EECA6674C1; Thu, 28 Apr 2022 03:03:06 -0700 (PDT) Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 773C31EC0535; Thu, 28 Apr 2022 12:03:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1651140181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=PgBjqy9vQg0VYpTLuefpsdMFD4lNCA09smFUUhKxkbQ=; b=o+/ay/k8tOLntCUuq4C/qtmunpu2Bol5mgc9WPOI2hN4GpvuDvxbJiHGAoCS300Qp1E2Rs Ccp05mNGghaGTesy4iqY5q1AmS70B9H0Tf51+vF+MfJFGtjNew/44it8RJ8YmtKkimfogv WTbY1Xg01IY/2tln7cK+ONkKq+PNJ8E= Date: Thu, 28 Apr 2022 12:02:58 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv5 03/12] efi/x86: Get full memory map in allocate_e820() Message-ID: References: <20220425033934.68551-1-kirill.shutemov@linux.intel.com> <20220425033934.68551-4-kirill.shutemov@linux.intel.com> <20220427234853.6kt67gjrwzrhgvoa@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220427234853.6kt67gjrwzrhgvoa@box.shutemov.name> Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Thu, Apr 28, 2022 at 02:48:53AM +0300, Kirill A. Shutemov wrote: > Right. That's true. But having goto here makes patch 5/12 a bit cleaner. Ok, let's take our time machine and go into the future: This patch is in git, there's no concept of "next patch" anymore - and someone is staring at it for whatever reason. Someone is wondering: why the hell was this done this way? And which is that "next patch"? Someone probably needs to sort them in the application order to figure out which next patch the author is talking about... See what I mean? Also, if this hunk + + if (IS_ENABLED(CONFIG_UNACCEPTED_MEMORY)) + status = allocate_unaccepted_memory(params, nr_desc, map); + is what this is all about, then no, this confusion is not even worth it - please make sure your patches make sense on their own. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette