Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

kernel test robot
2022-07-28T21:20:54Z

Hi Markuss,

I love your patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on efi/next staging/staging-testing usb/usb-testing linus/master v5.19-rc8 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220728-223117
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220729/202207290523.Br8Zr7V3-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/b6a59e731326deaa78f7dcbd97520e2eed2bc707
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Markuss-Broks/Add-generic-framebuffer-support-to-EFI-earlycon-driver/20220728-223117
git checkout b6a59e731326deaa78f7dcbd97520e2eed2bc707
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/video/fbdev/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

drivers/video/fbdev/earlycon.c: In function 'simplefb_earlycon_map':
>> drivers/video/fbdev/earlycon.c:65:16: error: implicit declaration of function 'early_memremap_prot'; did you mean 'early_memremap'? [-Werror=implicit-function-declaration]
65 | return early_memremap_prot(info.phys_base + start, len, pgprot_val(fb_prot));
| ^~~~~~~~~~~~~~~~~~~
| early_memremap
>> drivers/video/fbdev/earlycon.c:65:16: warning: returning 'int' from a function with return type 'void *' makes pointer from integer without a cast [-Wint-conversion]
65 | return early_memremap_prot(info.phys_base + start, len, pgprot_val(fb_prot));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
{standard input}: Assembler messages:
{standard input}:210: Error: Register number out of range 0..0
{standard input}:211: Error: Register number out of range 0..0
{standard input}:211: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:211: Warning: Only the first path encountering the conflict is reported
{standard input}:210: Warning: This is the location of the conflicting usage
{standard input}:212: Error: Register number out of range 0..0
{standard input}:212: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:212: Warning: Only the first path encountering the conflict is reported
{standard input}:210: Warning: This is the location of the conflicting usage
{standard input}:212: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:212: Warning: Only the first path encountering the conflict is reported
{standard input}:211: Warning: This is the location of the conflicting usage
{standard input}:214: Error: Register number out of range 0..0
{standard input}:214: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:214: Warning: Only the first path encountering the conflict is reported
{standard input}:210: Warning: This is the location of the conflicting usage
{standard input}:214: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:214: Warning: Only the first path encountering the conflict is reported
{standard input}:211: Warning: This is the location of the conflicting usage
{standard input}:214: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:214: Warning: Only the first path encountering the conflict is reported
{standard input}:212: Warning: This is the location of the conflicting usage
{standard input}:215: Error: Register number out of range 0..0
{standard input}:215: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:215: Warning: Only the first path encountering the conflict is reported
{standard input}:210: Warning: This is the location of the conflicting usage
{standard input}:215: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:215: Warning: Only the first path encountering the conflict is reported
{standard input}:211: Warning: This is the location of the conflicting usage
{standard input}:215: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:215: Warning: Only the first path encountering the conflict is reported
{standard input}:212: Warning: This is the location of the conflicting usage
{standard input}:215: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:215: Warning: Only the first path encountering the conflict is reported
{standard input}:214: Warning: This is the location of the conflicting usage
{standard input}:216: Error: Register number out of range 0..0
{standard input}:216: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:216: Warning: Only the first path encountering the conflict is reported
{standard input}:210: Warning: This is the location of the conflicting usage
{standard input}:216: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:216: Warning: Only the first path encountering the conflict is reported
{standard input}:211: Warning: This is the location of the conflicting usage
{standard input}:216: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:216: Warning: Only the first path encountering the conflict is reported
{standard input}:212: Warning: This is the location of the conflicting usage
{standard input}:216: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:216: Warning: Only the first path encountering the conflict is reported
{standard input}:214: Warning: This is the location of the conflicting usage
{standard input}:216: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 35
{standard input}:216: Warning: Only the first path encountering the conflict is reported
{standard input}:215: Warning: This is the location of the conflicting usage
{standard input}:220: Error: Register number out of range 0..0
{standard input}:376: Error: Register number out of range 0..1
{standard input}:376: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:376: Warning: Only the first path encountering the conflict is reported
{standard input}:374: Warning: This is the location of the conflicting usage
{standard input}:378: Error: Register number out of range 0..1
{standard input}:378: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:378: Warning: Only the first path encountering the conflict is reported
{standard input}:374: Warning: This is the location of the conflicting usage
{standard input}:378: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:378: Warning: Only the first path encountering the conflict is reported
{standard input}:376: Warning: This is the location of the conflicting usage
{standard input}:379: Error: Register number out of range 0..1
{standard input}:379: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:379: Warning: Only the first path encountering the conflict is reported
{standard input}:374: Warning: This is the location of the conflicting usage
{standard input}:379: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:379: Warning: Only the first path encountering the conflict is reported
{standard input}:376: Warning: This is the location of the conflicting usage
{standard input}:379: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:379: Warning: Only the first path encountering the conflict is reported
{standard input}:378: Warning: This is the location of the conflicting usage
{standard input}:380: Error: Register number out of range 0..1
{standard input}:380: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:380: Warning: Only the first path encountering the conflict is reported
{standard input}:374: Warning: This is the location of the conflicting usage
{standard input}:380: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:380: Warning: Only the first path encountering the conflict is reported
{standard input}:376: Warning: This is the location of the conflicting usage
{standard input}:380: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:380: Warning: Only the first path encountering the conflict is reported
{standard input}:378: Warning: This is the location of the conflicting usage
{standard input}:380: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:380: Warning: Only the first path encountering the conflict is reported
{standard input}:379: Warning: This is the location of the conflicting usage
{standard input}:383: Error: Register number out of range 0..1
{standard input}:384: Error: Register number out of range 0..1
{standard input}:384: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 37
{standard input}:384: Warning: Only the first path encountering the conflict is reported
{standard input}:383: Warning: This is the location of the conflicting usage

vim +65 drivers/video/fbdev/earlycon.c

56
57 static __ref void *simplefb_earlycon_map(unsigned long start, unsigned long len)
58 {
59 pgprot_t fb_prot;
60
61 if (info.virt_base)
62 return info.virt_base + start;
63
64 fb_prot = PAGE_KERNEL;
> 65 return early_memremap_prot(info.phys_base + start, len, pgprot_val(fb_prot));
66 }
67

--
0-DAY CI Kernel Test Service