From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5565EC3F6B0 for ; Wed, 17 Aug 2022 21:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233927AbiHQVfD (ORCPT ); Wed, 17 Aug 2022 17:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241642AbiHQVfC (ORCPT ); Wed, 17 Aug 2022 17:35:02 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ACC877E95; Wed, 17 Aug 2022 14:35:01 -0700 (PDT) Received: from zn.tnic (p200300ea971b98b0329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:98b0:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 61E331EC058B; Wed, 17 Aug 2022 23:34:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1660772095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ru/cgvADbJiW8w5IiV58rSJlrqdyDvFI3tr2tbrj/vk=; b=Y+gh/Xt8pqyWjuRv7JYblZFKoRXX7/zOdUGBXwql0qeCTZ/QkNXwzyqNptcpiWSPnWPrdz Rf4D5jf6rvjEJeZzhsMbVa4kcly9dyKf3qStJYPKewC8ZUTXmyNRUyY0jtit9chxIf2mHM NfEriH4Z3NrRDGDubdKMUGpVPJxAqkI= Date: Wed, 17 Aug 2022 23:34:48 +0200 From: Borislav Petkov To: "Kani, Toshi" Cc: Justin He , Ard Biesheuvel , Len Brown , James Morse , Tony Luck , Mauro Carvalho Chehab , Robert Richter , Robert Moore , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "devel@acpica.org" , "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , "linux-efi@vger.kernel.org" , nd , "stable@kernel.org" Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Message-ID: References: <20220811091713.10427-1-justin.he@arm.com> <20220811091713.10427-3-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, Aug 17, 2022 at 09:09:41PM +0000, Kani, Toshi wrote: > Since then, the change below enabled ghes_edac on Arm without this > known-good platforms check. > > commit eaa3a1d46 ("EDAC, ghes: Make platform-based whitelisting x86-only") Bah, I had forgotten about that one... In any case, edac_mc_add_mc* is too late in the init path - that check should happen as the very first thing in the driver init function. And looking at the ARM64 EDAC drivers, they're only a couple: thunderx, xgene, bluefield, dmc-520... And I'd still prefer if their maintainers explicitly ACK such a change to call ghes_get_devices() (for a lack of a better idea) and not enable ghes_edac on them blindly. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette