From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EB6C19F2D for ; Tue, 9 Aug 2022 12:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbiHIMRi (ORCPT ); Tue, 9 Aug 2022 08:17:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230380AbiHIMRh (ORCPT ); Tue, 9 Aug 2022 08:17:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7054DF51 for ; Tue, 9 Aug 2022 05:17:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86DD1B8118F for ; Tue, 9 Aug 2022 12:17:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 167E0C433C1; Tue, 9 Aug 2022 12:17:31 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="nH7s8dX9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1660047450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yTUBmcb7StG1xZ+XFh2SpEbQEQFJ+Uex4VrAw/Y2TfU=; b=nH7s8dX98oiqdhz7UDPdTm8bCw/tYsAznVG0QysdzDwoL/iN/GvM2RVGAgOTKMJEwwQqry UWSprxgkprU/UQ2CUo8qDziNCzLOHbbwgeyN9K5fwtt94m4Wk0JSUh4HKT9YJiK3sWBUQi /RDzy0blulxNDbH60UShrC7J2YlvHjI= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 6fcacff3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 9 Aug 2022 12:17:30 +0000 (UTC) Date: Tue, 9 Aug 2022 14:17:23 +0200 From: "Jason A. Donenfeld" To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Xiaoyao Li , Richard Henderson , Peter Maydell , "Michael S . Tsirkin" , Daniel P =?utf-8?B?LiBCZXJyYW5nw6k=?= , Gerd Hoffmann , Ard Biesheuvel , Laszlo Ersek , linux-efi@vger.kernel.org Subject: Re: [PATCH v3] hw/i386: place setup_data at fixed place in memory Message-ID: References: <20220804230411.17720-1-Jason@zx2c4.com> <40fdfb11-1e40-a36a-d3a4-fcbef546a78a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Hey Paolo, On Fri, Aug 05, 2022 at 02:47:27PM +0200, Jason A. Donenfeld wrote: > Hi Paolo, > > On Fri, Aug 05, 2022 at 10:10:02AM +0200, Paolo Bonzini wrote: > > On 8/5/22 01:04, Jason A. Donenfeld wrote: > > > + /* Nothing else uses this part of the hardware mapped region */ > > > + setup_data_base = 0xfffff - 0x1000; > > > > Isn't this where the BIOS lives? I don't think this works. > > That's the segment dedicated to ROM and hardware mapped addresses. So > that's a place to put ROM material. No actual software will use it. > > Jason Unless I've misread the thread, I don't think there are any remaining objections, right? Can we try merging this and seeing if it fixes the issue for good? Jason