Re: [GIT PULL] EFI updates for v6.15

[Ingo Molnar <mingo@kernel.org>]

* Ard Biesheuvel <ardb@kernel.org> wrote:

> (cc Ingo)
> 
> On Sat, 29 Mar 2025 at 19:46, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Fri, 28 Mar 2025 at 00:05, Ard Biesheuvel <ardb+git@google.com> wrote:
> > >
> > >  arch/x86/boot/compressed/efi_mixed.S               | 341 ---------------------
> > >  drivers/firmware/efi/libstub/x86-mixed.S           | 253 +++++++++++++++
> >
> > I've pulled this, but I'm not super-happy about it.
> >
> > We have been pretty successful in keeping assembler files in the 
> > arch/ directory, and I really think we should strive to continue 
> > that.
> >
> > Do we have a few drivers that have arch-specific assembly code? 
> > Yes. But it certainly isn't something to make more common.
> >
> > And did we already do that zboot-header.S thing earlier? Also yes, 
> > but that one is afaik actually architecture-neutral and doesn't 
> > have any architecture *instructions* in it, it's just data layout 
> > afaik (and no, I don't know why it was done as a '*.S' file)
> >
> > IOW, I really wish you would move this back to arch/x86 somewhere. 
> > Please?
> >
> 
> Fair enough. Note that this applies to la57toggle.S as well, which 
> was moved in a patch that went via the -tip tree this cycle.
> 
> It doesn't matter that much where the files live, as long as they are 
> disentangled from the traditional decompressor. (For C files, it is 
> important that they are built using the EFI stub's C flags, but for 
> asm files, that makes little difference)
> 
> Does arch/x86/lib sound like a reasonable place?

So all of this is boot code (early EFI runtime calls), right? Please 
move anything fundamentally low level boot related to arch/x86/boot/. 
We can open up arch/x86/boot/efi/ or so, to decouple it from the 
decompressor.

Thanks,

	Ingo