Re: [GIT PULL] EFI updates for v6.15

[Ingo Molnar <mingo@kernel.org>]

* Ard Biesheuvel <ardb@kernel.org> wrote:

> So what I would like to propose for this arch/x86/boot/<something> 
> subdirectory is to move all these source files there, and build a 
> static library that can be pulled into the kernel proper as well as 
> the decompressor, using C flags etc that ensure that all code it 
> contains is safe for execution from the 1:1 mapping. This is how the 
> EFI stub static library is built, and also how the code in 
> arch/arm64/kernel/pi/ is constructed to ensure that it can safely run 
> from a virtual mapping that doesn't match the one the linker used at 
> build time.
> 
> How does that sound?

Sounds fantastic, related code should be together, like friends around 
a campfire.

Proposed locations, if it's 99% boot/init code (SYSTEM_BOOTING code):

	arch/x86/boot/efi/
	arch/x86/boot/efi/lib/
	arch/x86/boot/efilib/
	arch/x86/boot/lib/efi/

... or if there's a substantial runtime code (SYSTEM_RUNNING code):

	arch/x86/platform/efi/   # <--- already exists
	arch/x86/kernel/efi/

I'm a bit against the arch/x86/lib/ location for the simple reason
that the x86 library functions are usually simple self-contained 
regular-runtime facilities in C or asm with very little magic, which 
the EFI boot/stub code is as far away from as technologically possible. 
;-)

Look into arch/x86/lib/ and you'll see that EFI functionality doesn't 
really fit there.

Thanks,

	Ingo