From: Ingo Molnar <mingo@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-efi@vger.kernel.org
Subject: Re: [GIT PULL] EFI updates for v6.15
Date: Tue, 1 Apr 2025 11:08:09 +0200 [thread overview]
Message-ID: <Z-us-SG96wJ0BQCv@gmail.com> (raw)
In-Reply-To: <CAMj1kXGyjJeFkzHhxm-UzRw_9N26MHY2NeAJVEzLRugkiShAMQ@mail.gmail.com>
* Ard Biesheuvel <ardb@kernel.org> wrote:
> On Tue, 1 Apr 2025 at 11:32, Ingo Molnar <mingo@kernel.org> wrote:
> >
> >
> > * Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > > > Look into arch/x86/lib/ and you'll see that EFI functionality
> > > > doesn't really fit there.
> > >
> > > Again, EFI is only one aspect of this. The SEV-SNP startup code and
> > > the early 5-level paging are used by non-EFI boot as well. But they
> > > suffer from the same issue (C code that runs so early that it does
> > > not tolerate ordinary non-PIC codegen with instrumentation etc)
> > >
> > > Should we maybe classify this as startup code? And put it in
> > > arch/x86/boot/startup or arch/x86/kernel/startup?
> >
> > Yeah, so the canonical place for platform startup code is
> > arch/x86/platform/, we could certainly open up arch/x86/platform/efi/
> > there too, in addition to arch/x86/boot/efi/.
> >
>
> But what about code that has nothing to do with EFI? That is what I
> am asking about.
Would arch/x86/boot/startup/ or arch/x86/boot/init/ work? We can open
up an efi/ subdirectory within it. (but flat would be fine too.)
It would be an improvement to concentrate such code into a single
place, I think.
Thanks,
Ingo
next prev parent reply other threads:[~2025-04-01 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 7:05 [GIT PULL] EFI updates for v6.15 Ard Biesheuvel
2025-03-29 18:46 ` Linus Torvalds
2025-03-29 19:07 ` Ard Biesheuvel
2025-03-29 19:44 ` Linus Torvalds
2025-03-30 8:10 ` Ingo Molnar
2025-03-31 13:55 ` Ard Biesheuvel
2025-03-31 16:55 ` Ingo Molnar
2025-04-01 6:44 ` Ard Biesheuvel
2025-04-01 8:32 ` Ingo Molnar
2025-04-01 8:56 ` Ard Biesheuvel
2025-04-01 9:08 ` Ingo Molnar [this message]
2025-04-01 9:10 ` Ard Biesheuvel
2025-03-29 19:56 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-us-SG96wJ0BQCv@gmail.com \
--to=mingo@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox