From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13A0D1EC009 for ; Tue, 1 Apr 2025 09:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743498493; cv=none; b=XiDqlKlf2Bez6qeHS7rEleoT9Oc0kUNp4Z4obtgjwVLvsmtvwEZcuGEeNghEqkz4X/zNKmakUntKE5I9DkzX+eA5WfNw5mAJCoHswTimXqUHglrRFqeMcpBzGocwBnean8P0Y2FPx4E8S8RCQaqecw0xN4aH5N0h0wlaR5AzrVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743498493; c=relaxed/simple; bh=ywMfVZONBIix5F/njEsdUc863hABMZFh97L4a3b8F7k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gZLcBSnv9IbpwsRSyPYEKfkBhEN0EvxT60SOy77WIHIFJl+hdVGfBY5rDqahLg3vSZKWrSL3J6YWF+SG7ROCGSxOwzM/LdIu3+mtx1mHa2SFwValGA7ZTNhABgICCdDwpKoSxmEzRude6XrwGSjno5GMwPkz78+r2SAldiTK2ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MEeK5gCM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MEeK5gCM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 843DFC4CEE4; Tue, 1 Apr 2025 09:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743498492; bh=ywMfVZONBIix5F/njEsdUc863hABMZFh97L4a3b8F7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MEeK5gCMg1Qx3yx/TtcCEWwaJNPUIw6VyW38kLVEmr8maHo3OExwa7Uf2oWRnqHlB Av+4r07L9b8DnXOoqoEzydIL7p9vDEWxLV5N+WDCWw8bOmi5LOV9+qlwglAL8z9qZ8 ET9/0yjPRcAi3raplk+QV/SJaDD1/bT5R+cTf+Wm8ffU2iYAckkhAdR0GRl3pgaI+F FbnTEpHD6m/8dYFRMhqZqx8Ov2/CUAZAmYgbmTn2dYX9jbGQeCPUYmgrwZTx7J4IL5 ADRlvhWQ5Hya6VuskqOBL+58CFn5N53Uak+0j6GTxNaRTOwq3zE+kwVlOn+rY5FgE2 Bkk46GrYY846Q== Date: Tue, 1 Apr 2025 11:08:09 +0200 From: Ingo Molnar To: Ard Biesheuvel Cc: Linus Torvalds , linux-efi@vger.kernel.org Subject: Re: [GIT PULL] EFI updates for v6.15 Message-ID: References: <20250328070525.2248563-2-ardb+git@google.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Ard Biesheuvel wrote: > On Tue, 1 Apr 2025 at 11:32, Ingo Molnar wrote: > > > > > > * Ard Biesheuvel wrote: > > > > > > Look into arch/x86/lib/ and you'll see that EFI functionality > > > > doesn't really fit there. > > > > > > Again, EFI is only one aspect of this. The SEV-SNP startup code and > > > the early 5-level paging are used by non-EFI boot as well. But they > > > suffer from the same issue (C code that runs so early that it does > > > not tolerate ordinary non-PIC codegen with instrumentation etc) > > > > > > Should we maybe classify this as startup code? And put it in > > > arch/x86/boot/startup or arch/x86/kernel/startup? > > > > Yeah, so the canonical place for platform startup code is > > arch/x86/platform/, we could certainly open up arch/x86/platform/efi/ > > there too, in addition to arch/x86/boot/efi/. > > > > But what about code that has nothing to do with EFI? That is what I > am asking about. Would arch/x86/boot/startup/ or arch/x86/boot/init/ work? We can open up an efi/ subdirectory within it. (but flat would be fine too.) It would be an improvement to concentrate such code into a single place, I think. Thanks, Ingo