From: Lukas Wunner <lukas@wunner.de>
To: Lleyton Gray <lleyton@fyralabs.com>
Cc: gargaditya08@live.com, Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol
Date: Sun, 29 Dec 2024 10:59:46 +0100 [thread overview]
Message-ID: <Z3EdkuCBzTGzTHK3@wunner.de> (raw)
In-Reply-To: <20241228202212.89069-1-lleyton@fyralabs.com>
On Sat, Dec 28, 2024 at 12:21:58PM -0800, Lleyton Gray wrote:
> commit 71e49eccdca6 ("x86/efistub: Call Apple set_os protocol on dual GPU
> Intel Macs") calls the Apple set_os protocol, but only on T2 Macbook Pro
> models. This causes issues on other T2 models when an egpu is used.
How so? The commit specifically constrains the quirk only to
affected dual GPU MacBook Pros. So I don't quite see how this
would affect other T2 models?
And what kind of issues are you seeing? Could you provide
specifics please?
> Add two options which allow force enabling or disabling usage of the
> protocol to fix.
We generally try to avoid command line options. The kernel
should automatically determine whether to apply the quirk
or not. So I think the proper solution is to amend the
quirk such that it's applied to additional models or not
applied under certain circumstances.
Thanks,
Lukas
next prev parent reply other threads:[~2024-12-29 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 20:21 [PATCH] x86/efistub: Add options for forcing Apple set_os protocol Lleyton Gray
2024-12-29 9:59 ` Lukas Wunner [this message]
2024-12-29 10:08 ` Ard Biesheuvel
2024-12-29 10:38 ` Lukas Wunner
2024-12-29 18:22 ` Ard Biesheuvel
2024-12-30 3:09 ` Lleyton Gray
2025-02-10 19:25 ` Lukas Wunner
[not found] ` <PN3PR01MB7728B4C94846673A5FFACE29B80B2@PN3PR01MB7728.INDPRD01.PROD.OUTLOOK.COM>
2025-02-10 19:58 ` Lukas Wunner
2025-02-11 16:05 ` Aditya Garg
2025-02-13 4:56 ` Lukas Wunner
2025-02-10 20:09 ` Lukas Wunner
2025-02-11 5:45 ` Aditya Garg
2025-02-09 16:13 ` Aditya Garg
2025-02-10 10:40 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2025-02-10 10:51 Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3EdkuCBzTGzTHK3@wunner.de \
--to=lukas@wunner.de \
--cc=ardb@kernel.org \
--cc=gargaditya08@live.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lleyton@fyralabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox