From: Lukas Wunner <lukas@wunner.de>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Lleyton Gray <lleyton@fyralabs.com>,
gargaditya08@live.com, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org
Subject: Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol
Date: Sun, 29 Dec 2024 11:38:24 +0100 [thread overview]
Message-ID: <Z3EmoNWbkbYZ7NZO@wunner.de> (raw)
In-Reply-To: <CAMj1kXHWoD78QdFnEY_=Mtz02zN3rhN5+Skgv=fHG91TD8Mmvw@mail.gmail.com>
On Sun, Dec 29, 2024 at 11:08:55AM +0100, Ard Biesheuvel wrote:
> IIRC, the original issue is about not being able to use the discrete
> GPU with the built-in panel, and the issue about an external GPU did
> come up in the discussion - however, this does not affect the built-in
> panel at all.
The original issue was that the integrated GPU is hidden (powered off)
unless the set_os protocol is used. So only the discrete GPU is
available, which results in terrible battery life. Using set_os
keeps the iGPU exposed so the OS can switch to it and power off
the dGPU.
We could have solved this by checking whether there are two PCI devices
with VGA class in the system. But that would have triggered in the
iGPU + eGPU case. We wanted to avoid that and thus quirked for the
DMI product names instead.
Thanks,
Lukas
next prev parent reply other threads:[~2024-12-29 10:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-28 20:21 [PATCH] x86/efistub: Add options for forcing Apple set_os protocol Lleyton Gray
2024-12-29 9:59 ` Lukas Wunner
2024-12-29 10:08 ` Ard Biesheuvel
2024-12-29 10:38 ` Lukas Wunner [this message]
2024-12-29 18:22 ` Ard Biesheuvel
2024-12-30 3:09 ` Lleyton Gray
2025-02-10 19:25 ` Lukas Wunner
[not found] ` <PN3PR01MB7728B4C94846673A5FFACE29B80B2@PN3PR01MB7728.INDPRD01.PROD.OUTLOOK.COM>
2025-02-10 19:58 ` Lukas Wunner
2025-02-11 16:05 ` Aditya Garg
2025-02-13 4:56 ` Lukas Wunner
2025-02-10 20:09 ` Lukas Wunner
2025-02-11 5:45 ` Aditya Garg
2025-02-09 16:13 ` Aditya Garg
2025-02-10 10:40 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2025-02-10 10:51 Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3EmoNWbkbYZ7NZO@wunner.de \
--to=lukas@wunner.de \
--cc=ardb@kernel.org \
--cc=gargaditya08@live.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lleyton@fyralabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox