Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol

[Lukas Wunner <lukas@wunner.de>]

Hi Lleyton,

my apologies for the delay.

On Sun, Dec 29, 2024 at 07:09:15PM -0800, Lleyton Gray wrote:
> On 12/29/24 10:22, Ard Biesheuvel wrote:
> > On Sun, 29 Dec 2024 at 11:38, Lukas Wunner <lukas@wunner.de> wrote:
> > > The original issue was that the integrated GPU is hidden (powered off)
> > > unless the set_os protocol is used.  So only the discrete GPU is
> > > available, which results in terrible battery life.  Using set_os
> > > keeps the iGPU exposed so the OS can switch to it and power off
> > > the dGPU.
> > 
> > Yeah, so it would be good to know what issue are trying to fix with
> > this patch.
>
> I believe this is another issue that requires the same set_os quirk. In
> specific, amdgpu fails to initialize when using an AMD eGPU in a T2 system,
> unless the set_os protocol is used. Because it's currently quirked for the
> product names of dual-gpu T2 Macs, if you're on a system that doesn't match
> those names (ex. 2018 Mac Mini), there's no way to enable the protocol to
> get an eGPU working.

How does the amdgpu initialization issue manifest itself exactly?

Could you either provide full dmesg output both for the failing case
and the success case (i.e. with your patch)?

E.g. could you open a bug on bugzilla.kernel.org and attach the dmesg
output or at least provide a dmesg excerpt with the relevant amdgpu
initialization messages?

Any patch to fix the issue needs to provide a proper explanation
of what's going wrong without the patch and why, so that anyone
working on the code in the future can understand why the change
was made.  Just stating that amdgpu fails to initialize isn't
sufficient in my view.

Thanks,

Lukas