From: Alison Schofield <alison.schofield@intel.com>
To: "Koralahalli Channabasappa,
Smita" <Smita.KoralahalliChannabasappa@amd.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PATCH v7 2/2] cxl/pci: Add trace logging for CXL PCIe Port RAS errors
Date: Tue, 4 Mar 2025 13:10:11 -0800 [thread overview]
Message-ID: <Z8dsM1hJm7H3ddgj@aschofie-mobl2.lan> (raw)
In-Reply-To: <19fd5db5-cc52-4f05-8ecc-64a4eea3b9a1@amd.com>
On Tue, Mar 04, 2025 at 12:33:56PM -0800, Koralahalli Channabasappa, Smita wrote:
snip
> > > +TRACE_EVENT(cxl_port_aer_uncorrectable_error,
> > > + TP_PROTO(struct device *dev, u32 status, u32 fe, u32 *hl),
> > > + TP_ARGS(dev, status, fe, hl),
> > > + TP_STRUCT__entry(
> > > + __string(devname, dev_name(dev))
> > > + __string(parent, dev_name(dev->parent))
> >
> > Above devname, parent
>
> Ok I'm planning to keep as device and parent. Let me know if wording "host"
> is preferred over "parent".
Take a look at these in the same file that use memdev, 'host'.
Maybe you want to be similar.
TRACE_EVENT(cxl_aer_uncorrectable_error,
TRACE_EVENT(cxl_aer_correctable_error,
snip
>
next prev parent reply other threads:[~2025-03-04 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 22:11 [PATCH v7 0/2] acpi/ghes, cper, cxl: Process CXL CPER Protocol errors Smita Koralahalli
2025-02-26 22:11 ` [PATCH v7 1/2] acpi/ghes, cxl/pci: Process CXL CPER Protocol Errors Smita Koralahalli
2025-03-04 17:44 ` Ira Weiny
2025-03-05 0:56 ` Ira Weiny
2025-03-04 19:57 ` Yazen Ghannam
2025-03-04 20:16 ` Koralahalli Channabasappa, Smita
2025-02-26 22:11 ` [PATCH v7 2/2] cxl/pci: Add trace logging for CXL PCIe Port RAS errors Smita Koralahalli
2025-03-04 17:45 ` Ira Weiny
2025-03-04 18:56 ` Alison Schofield
2025-03-04 20:33 ` Koralahalli Channabasappa, Smita
2025-03-04 21:10 ` Alison Schofield [this message]
2025-03-04 21:21 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8dsM1hJm7H3ddgj@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox