From: Sudeep Holla <sudeep.holla@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-efi@vger.kernel.org
Subject: Re: [PATCH v2 5/8] virt: efi_secret: Transition to the faux device interface
Date: Wed, 19 Mar 2025 13:15:38 +0000 [thread overview]
Message-ID: <Z9rDely6YxIQZTrK@bogus> (raw)
In-Reply-To: <CAMj1kXGJkApH73r9qEGABe3M4pXP2gMW3tDXfz2F6WGPZ3nhug@mail.gmail.com>
On Tue, Mar 18, 2025 at 06:10:41PM +0100, Ard Biesheuvel wrote:
> On Tue, 18 Mar 2025 at 18:02, Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > The EFI secret area driver does not require the creation of a platform
> > device. Originally, this approach was chosen for simplicity when the
> > driver was first implemented.
> >
> > With the introduction of the lightweight faux device interface, we now
> > have a more appropriate alternative. Migrate the driver to utilize the
> > faux bus, given that the platform device it previously created was not
> > a real one anyway. This will simplify the code, reducing its footprint
> > while maintaining functionality.
> >
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: linux-efi@vger.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> So how is module autoload supposed to work with this driver?
>
IIUC, you are right. It doesn't work. I got carried away how efi_pstore was
autoloaded in Ubuntu even without alias or platform/faux device creation. I
don't know how yet but that works. This modules doesn't.
So we may have to retain platform device/driver for autoloading reasons ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-03-19 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 17:01 [PATCH v2 0/8] drivers: Transition to the faux device interface Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 4/8] rtc: efi: " Sudeep Holla
2025-04-08 14:45 ` (subset) " Alexandre Belloni
2025-04-08 15:01 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 5/8] virt: efi_secret: " Sudeep Holla
2025-03-18 17:10 ` Ard Biesheuvel
2025-03-19 13:15 ` Sudeep Holla [this message]
2025-03-19 14:24 ` Greg Kroah-Hartman
2025-03-19 14:30 ` Sudeep Holla
2025-03-18 17:01 ` [PATCH v2 6/8] efi: efivars: " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9rDely6YxIQZTrK@bogus \
--to=sudeep.holla@arm.com \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox