From: Lukas Wunner <lukas@wunner.de>
To: Aditya Garg <gargaditya08@live.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
Kerem Karabay <kekrby@gmail.com>,
Orlando Chamberlain <orlandoch.dev@gmail.com>
Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os protocol
Date: Mon, 1 Jul 2024 07:34:58 +0200 [thread overview]
Message-ID: <ZoJAAifMqIDXdniv@wunner.de> (raw)
In-Reply-To: <75C90B50-9AB9-4F0A-B2CD-43427354D15C@live.com>
On Sun, Jun 30, 2024 at 07:24:54PM +0000, Aditya Garg wrote:
> @@ -335,9 +359,12 @@ static const efi_char16_t apple[] = L"Apple";
>
> static void setup_quirks(struct boot_params *boot_params)
> {
> - if (IS_ENABLED(CONFIG_APPLE_PROPERTIES) &&
> - !memcmp(efistub_fw_vendor(), apple, sizeof(apple)))
> - retrieve_apple_device_properties(boot_params);
> + if (!memcmp(efistub_fw_vendor(), apple, sizeof(apple))) {
> + if (IS_ENABLED(CONFIG_APPLE_PROPERTIES)) {
> + retrieve_apple_device_properties(boot_params);
> + }
> + apple_set_os();
> + }
Nit: Unnecessary curly braces around retrieve_apple_device_properties().
(And I'd appreciate a blank line between it and the apple_set_os() call.
next prev parent reply other threads:[~2024-07-01 5:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 19:24 [PATCH v2] efi: libstub: add support for the apple_set_os protocol Aditya Garg
2024-07-01 4:45 ` Orlando Chamberlain
2024-07-01 5:11 ` Ard Biesheuvel
2024-07-01 5:34 ` Lukas Wunner [this message]
2024-07-01 5:38 ` Ard Biesheuvel
2024-07-01 5:50 ` Lukas Wunner
2024-07-01 5:56 ` Ard Biesheuvel
2024-07-01 6:41 ` Lukas Wunner
2024-07-01 7:30 ` Ard Biesheuvel
2024-07-01 7:44 ` Lukas Wunner
2024-07-01 7:49 ` Lukas Wunner
2024-07-01 7:51 ` Ard Biesheuvel
2024-07-01 7:53 ` Aditya Garg
2024-07-01 8:02 ` Aditya Garg
2024-07-01 8:14 ` Lukas Wunner
2024-07-01 9:10 ` Aditya Garg
2024-07-01 10:40 ` Aditya Garg
2024-07-01 7:35 ` Lukas Wunner
2024-07-01 13:14 ` Orlando Chamberlain
2024-07-01 13:44 ` Lukas Wunner
2024-07-01 6:52 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoJAAifMqIDXdniv@wunner.de \
--to=lukas@wunner.de \
--cc=ardb@kernel.org \
--cc=gargaditya08@live.com \
--cc=hdegoede@redhat.com \
--cc=kekrby@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orlandoch.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox