From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D91F61674; Mon, 1 Jul 2024 07:49:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719820155; cv=none; b=bog1eUc8l8DBiiasPfzmD+VWIMRg0lgT3zZhG7bOFkhx+nb1YFqxo/fCS33OjpCbZRDOiHaGl/p6OXzhbdOkcgmstBhi1n/cIfiaBEg7fxvlWsW0i1FM64u6dEqqmtCFgZpEQ+jlYklisaEKj6Z3tB9zSDkzrmSzHK/i3rUrU1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719820155; c=relaxed/simple; bh=/N9YpHzzw1kXMTEeN9PDz2gD0Ep7EP+Zecpj5e8FzJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s9u653fGV1NXFkVaTC3Q1H2VuF6MwERUlJYN0a01MECIcLv5aGbsLvYbzqg7sEdLlYVk9tFUNhnepMcojk4P5/JxPlVCoVGf5dyY2mluRAaLd0SXRQiab4iYV6D0rClgkGMjYNy1GZN3az3skC9c4DAXlKwrJHK/oIDNmVLfVO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 7E5253000C985; Mon, 1 Jul 2024 09:49:09 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 6B138388376; Mon, 1 Jul 2024 09:49:09 +0200 (CEST) Date: Mon, 1 Jul 2024 09:49:09 +0200 From: Lukas Wunner To: Ard Biesheuvel Cc: Aditya Garg , Hans de Goede , Linux Kernel Mailing List , "linux-efi@vger.kernel.org" , Kerem Karabay , Orlando Chamberlain Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os protocol Message-ID: References: <75C90B50-9AB9-4F0A-B2CD-43427354D15C@live.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 01, 2024 at 09:44:21AM +0200, Lukas Wunner wrote: > > +static bool apple_match_product_name(void) > > Maybe something like apple_has_dual_gpu() ? On second thought, maybe not. A neutral name allows us to add models like the MacBook Airs once we have support for them in the SPI keyboard driver. Thanks, Lukas