From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F0616F826 for ; Fri, 13 Sep 2024 23:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726268854; cv=none; b=lsmwJKmImRnnq7rjk0Mh9HphXKQiN7w2T14RP9hLqUFdyIFZ1BY6dSabDFE6PFBL1MlEWC5UX2ot995T9x/lGKXWolLRpOGCgpN+mqZYzG49iwlJS/1QxdRAEMVWni8dWKe3ptv6Dj89JsohfO3euY/VjKVzKJz7yYZn911SGAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726268854; c=relaxed/simple; bh=XK6gtAi1OXFeL1vs4htfDCwnlmFgFzZBC0wIvvmcOSs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LuG31L0QUwA75lJx1jF6Bafypk6zaRoFOOEMJ+/W5aASflTzuHuG4EaVn1IirQuaSQE7ahwLTWwFP7XFwuZb4TqV7lrmzmSKr5N+n9sfmw+DW+yM43Piz7mB/000RfkyAfxbyi7zY3zbhvk/xKiy4a4a6Twv7BQvAUcVs7Gn/FY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=gp+51+qA; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="gp+51+qA" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7a4df9dc885so219592485a.0 for ; Fri, 13 Sep 2024 16:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1726268852; x=1726873652; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DXwgSapoWxOYR4k+GSYJnKgxe+7fV9y5qWNXQnS4uNU=; b=gp+51+qA50eyqsKv0GS9SOW8TOLK/F+gTvwPeDQE9vFEC9hOMA3i/UdsTPQeSDsSzd aT0VA6U5kXKHiUlNTs/iQhUNHctHbgG9Xxzg1jte6s0q7SJsNUXOm8q7Bln6vOdrJl65 oL9dxWE0gd9YWtP/odxyzdtaR98kMqyCjwZhOJwuejYqykplScSplycbq5V24fPVTjbP bWzRGbFqQb4hDaP5K+AA3NtOoGJuYggf+IfWxiaS5W194VhG7FBLlyNijl6mr4zNxOh5 rqBwUeE4Miz5vFd4UTcQeHQqkLDL61+HB0n9CL5hksxCixxuLYxyj6HVaEQ1GFlsEQsc NB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726268852; x=1726873652; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DXwgSapoWxOYR4k+GSYJnKgxe+7fV9y5qWNXQnS4uNU=; b=sFstZdESCKIQ0yFWbR4mHe9SaJJejdgbGukn7BVGArlITMkIFi3BW/Ae/bEedj9UG/ cUeOVU0kFYDyWtHN/LIgVI4xdYjai3IvwEQU/3C2q/4DAuaXLAHu8n/qdDNVzHfe7EO3 F+VjgPx87ow5imJ42ACk/owPl7Z+G/RgOyB5AyVdY9wXBd7/A6qvq2Dy7HXaJE9ybRmA Cel9ijgDOgh1lTCo1bQVcoSGI3PDAkdEQzwmQQAr6xsXva8dzgcvM44bpqJWcX7v5cq5 qndKa6ZnmUALRmExXGbuC6CIYgJI/Yf4sGIqy4PIXe6S+1Aro3CgX1T9bszdHnLbo6Qe K3gQ== X-Gm-Message-State: AOJu0YyDw/AqxUowZJJ3kD7LbqsvLD/+u/AIr4fn9SRT1WjN/fTTVMB7 JkMl6QRBETFP84ep3QAWtovBkuPr7OH4kINRSQ3WY8oz7Dtm3HbbmQJXmNTAlSs= X-Google-Smtp-Source: AGHT+IEiZLgBcbTQhZcrplm7xCblgu9LXIY0zBXfx9erBzLwSfEZdNy/mlwQXMlUgbDZ8Zs72aCDQw== X-Received: by 2002:a05:620a:172a:b0:7a9:b2f4:42e0 with SMTP id af79cd13be357-7a9bf97c1d8mr2753825885a.15.1726268852134; Fri, 13 Sep 2024 16:07:32 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ab3e9b1c73sm11720985a.61.2024.09.13.16.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 16:07:31 -0700 (PDT) Date: Fri, 13 Sep 2024 19:06:45 -0400 From: Gregory Price To: Ilias Apalodimas Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, ardb@kernel.org, leitao@debian.org, usamaarif642@gmail.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH 3/6] libstub,tpm: provide indication of failure when getting event log Message-ID: References: <20240906202745.11159-1-gourry@gourry.net> <20240906202745.11159-4-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Sep 13, 2024 at 04:10:08PM +0300, Ilias Apalodimas wrote: > On Fri, 13 Sept 2024 at 15:58, Gregory Price wrote: > > > > > > - if (status != EFI_SUCCESS || !log_location) > > > > + if (status != EFI_SUCCESS || !log_location) { > > > > + efi_err("TPM unable to provide Event Log\n"); > > > > > > s/provide/retrieve/ and yes the print is going to be useful. Do you > > > know if the EventLog is mandatory. Reading at the spec GetEventlog > > > only has 2 return values, which implies you can't return "Not > > > supported", but it's not explicitly stated anywhere > > > > > > > I believe it is mandatory from my reading of the spec - but the > > "Final Event Log" was only added in 2.0. We report an error when > > 2.0 is reported but the final event log is not supported, so i figure > > we should probably report when the event log fails as well. > > Yea I am fine with that, I was just wondering if we should do _err or > _warn. I am fine with the error > > /Ilias Per Ard's notes on patch 6 i'm going to drop this. These prints apparently don't actually end up anywhere. ~Gregory