From: Rik van Riel <riel@surriel.com>
To: Breno Leitao <leitao@debian.org>,
Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, puranjay@kernel.org,
usamaarif642@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH 1/2] arm64: efi: Fix NULL pointer dereference by initializing user_ns
Date: Tue, 23 Dec 2025 14:24:33 -0500 [thread overview]
Message-ID: <a060d8ec023cb7b8dbec0cb4105d03fb24c57a3d.camel@surriel.com> (raw)
In-Reply-To: <20251223-efi_fix_619-v1-1-e0146b8b9d73@debian.org>
On Tue, 2025-12-23 at 02:55 -0800, Breno Leitao wrote:
>
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index a9070d00b833..55452e61af31 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -73,6 +73,7 @@ struct mm_struct efi_mm = {
> MMAP_LOCK_INITIALIZER(efi_mm)
> .page_table_lock =
> __SPIN_LOCK_UNLOCKED(efi_mm.page_table_lock),
> .mmlist =
> LIST_HEAD_INIT(efi_mm.mmlist),
> + .user_ns = &init_user_ns,
> .cpu_bitmap = { [BITS_TO_LONGS(NR_CPUS)] = 0},
> #ifdef CONFIG_SCHED_MM_CID
> .mm_cid.lock =
> __RAW_SPIN_LOCK_UNLOCKED(efi_mm.mm_cid.lock),
Seems legit?
Acked-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
next prev parent reply other threads:[~2025-12-23 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 10:55 [PATCH 0/2] arm64: efi: Fix NULL pointer crash in 6.19-rc2 Breno Leitao
2025-12-23 10:55 ` [PATCH 1/2] arm64: efi: Fix NULL pointer dereference by initializing user_ns Breno Leitao
2025-12-23 19:24 ` Rik van Riel [this message]
2025-12-23 10:55 ` [PATCH 2/2] kthread: Warn if mm_struct lacks user_ns in kthread_use_mm() Breno Leitao
2025-12-23 19:31 ` Rik van Riel
2025-12-26 10:10 ` [PATCH 0/2] arm64: efi: Fix NULL pointer crash in 6.19-rc2 Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a060d8ec023cb7b8dbec0cb4105d03fb24c57a3d.camel@surriel.com \
--to=riel@surriel.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay@kernel.org \
--cc=usamaarif642@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox