From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline Date: Tue, 5 Jun 2018 11:06:22 -0700 Message-ID: References: <20180605170532.170361-1-ndesaulniers@google.com> <20180605170532.170361-3-ndesaulniers@google.com> <26c7fd1c-ab40-368f-c2e3-43a6b45157fd@zytor.com> <0dd024cd-e05a-0d67-c1bf-1a532714bb1a@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Nick Desaulniers Cc: linux-efi@vger.kernel.org, brijesh.singh@amd.com, boris.ostrovsky@oracle.com, "J. Kiszka" , Will Deacon , jarkko.sakkinen@linux.intel.com, virtualization@lists.linux-foundation.org, Masahiro Yamada , Manoj Gupta , akataria@vmware.com, Thiebaud Weksteen , mawilcox@microsoft.com, x86@kernel.org, Greg Hackmann , Matthias Kaehlcke , geert@linux-m68k.org, David Rientjes , Andrey Ryabinin , thomas.lendacky@amd.com, Arnd Bergmann , Linux Kbuild mailing list , Kees Cook , rostedt@goodmis.org, Cao jin , Michal Marek , Josh Poimboeuf , sedat.di List-Id: linux-efi@vger.kernel.org On 06/05/18 10:52, Nick Desaulniers wrote: > > Does the kernel have a different calling convention for 32b x86? How > does that work? regparm=3? Does that need to be added to the > declaration? > Yes, -mregparm=3. No, doesn't need to be added to the declaration. >> Something like this added to might be useful; then you can >> simply: >> >> push %_ASM_ARG1 >> >> Version with fixed typo... > > Oh, nice, thanks! I'll pick this up and add it to my patch set for v3 > (or did you want me to review/sign-off now?) I can pick up Sedat's > suggestion. > Add it to your patchset and add your own signoff underneath mine. -hpa