From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [PATCH v6 25/34] swiotlb: Add warnings for use of bounce buffers with SME Date: Thu, 15 Jun 2017 08:23:17 -0500 Message-ID: References: <20170607191309.28645.15241.stgit@tlendack-t1.amdoffice.net> <20170607191732.28645.42876.stgit@tlendack-t1.amdoffice.net> <20170614165052.fyn5t4gkq5leczcc@pd.tnic> <33d1debc-c684-cba1-7d95-493678f086d0@amd.com> <20170615090832.ncmq2kgom32cchhw@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170615090832.ncmq2kgom32cchhw@pd.tnic> Content-Language: en-US Sender: owner-linux-mm@kvack.org To: Borislav Petkov Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander List-Id: linux-efi@vger.kernel.org On 6/15/2017 4:08 AM, Borislav Petkov wrote: > On Wed, Jun 14, 2017 at 02:49:02PM -0500, Tom Lendacky wrote: >> I guess I don't need the sme_active() check since the second part of the >> if statement can only ever be true if SME is active (since mask is >> unsigned). > > ... and you can define sme_me_mask as an u64 directly (it is that already, > practically, as we don't do SME on 32-bit) and then get rid of the cast. Let me look into that. There are so many places that are expecting an unsigned long I'll have to see how that all works out from a build perspective. Thanks, Tom > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org