From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74AC922B5AD; Fri, 31 Oct 2025 04:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761883970; cv=none; b=T0/GefZ8h3wl6OArW9sI3FXQVzhrmo/sLW/S4pzeKUyrZ0uhhPlvzeVEZV5l+b5eBqxg2GGR05eVND6aIuyTIaLj6U+xrmjGypnoe3FhWlqX2lTbY4TtrReEob64IUpu6SsAZ9ydzuUmb1+nakOpgah8JjhEgH9BuBNPmyr0MpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761883970; c=relaxed/simple; bh=Mzlx1Jki3My90PskIq5MtUmOdsEdvQ1YbxyQk8t4p7I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PqoJWzP/2wt0icwYoGRqz/4zuyHc1bwK9joFUfLZ0XvJahINfrQVbVrwQMkuMcmyk+ndimQVkI1HZBL2o5KtL486sh8zCk/kvkjoowpGm6dya9S7adsqYJoSki+3jkNRvmKpMbLgVx8MWkGKKskP0yQ/qwqBEXrhSjknVbNW7Ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=blwXw/iq; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="blwXw/iq" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7631425CC7; Fri, 31 Oct 2025 05:12:44 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aAQWNjLXEiVO; Fri, 31 Oct 2025 05:12:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1761883963; bh=Mzlx1Jki3My90PskIq5MtUmOdsEdvQ1YbxyQk8t4p7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=blwXw/iqmeep3zsYeN43m2KK2dR4wIw5kQXG/0YO0QKL32l86WcFNcvrENBUHaQwc 9jWd1J83d4FE1kTRhKKe12e7ZPnmS6Vf19f7CQGOjoCIYsdEJb8n27+EVshFNFFidu psKZZVlyziI6sSEOMR+q4xuU/I5H/gPZ6WfVN3XiKubD17mzwNbgK+lzozRXdIz2L5 In+mzXmtrFOHz9vxBNP6Hrx3KxZkyxY0peXQ6Pz06AZMhjI7W0N5sXLVISXuII/xZo 5f+gYo/s5bKYyklK7oKlGuwg5f1hYZ7RXRLs1TaxmIaWnY09+GiQLQ7/qfIUaWGqKq ptarl34+4hRiw== Date: Fri, 31 Oct 2025 04:12:25 +0000 From: Yao Zi To: Qiang Ma , ardb@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr Cc: linux-efi@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efi/riscv: Remove the useless failure return message print Message-ID: References: <20251031024328.735161-1-maqianga@uniontech.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251031024328.735161-1-maqianga@uniontech.com> On Fri, Oct 31, 2025 at 10:43:28AM +0800, Qiang Ma wrote: > In the efi_create_mapping() in arch/riscv/kernel/efi.c, > the return value is always 0, and this debug message > is unnecessary. So, remove it. Should we make efi_create_mapping() return void at the same time, if it will never fail? Regards, Yao Zi > Signed-off-by: Qiang Ma