Re: [PATCH] efi/riscv: Remove the useless failure return message print

Ard Biesheuvel
2025-11-26T06:38:19Z

On Wed, 26 Nov 2025 at 03:53, Qiang Ma <maqianga@uniontech.com> wrote:
>
>
> 在 2025/11/26 08:27, Paul Walmsley 写道:
> > On Fri, 31 Oct 2025, Qiang Ma wrote:
> >
> >> In the efi_create_mapping() in arch/riscv/kernel/efi.c,
> >> the return value is always 0, and this debug message
> >> is unnecessary. So, remove it.
> >>
> >> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> > Considering that Ard doesn't think efi_create_mapping() should be changed
> > to remove the return value, and that the ARM version of this code retains
> > the debug message, we should probably keep things the way they are. But
> > if you can get a Reviewed-by: or an Acked-by: from Ard, I'd take it.
> Hi, Ard, what are your suggestions for this patch?
>
> Could you add a Reviewed-by: or an Acked-by: to this patch?

I already queued this up in efi/next