linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: francesco <francescopompo2@gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Francesco Pompò" <francescopompo2@gmail.com>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efistub/smbios: Add fallback for SMBIOS record lookup
Date: Mon, 3 Nov 2025 14:14:43 +0100	[thread overview]
Message-ID: <aQiqw1kX8br_KBnT@workstation> (raw)
In-Reply-To: <CAMj1kXEP=nByL5+R2Ch-PLSKnziEyyK_rLZL=wcvKRNcBPTJbg@mail.gmail.com>

On Mon, Nov 03, 2025 at 02:11:31PM +0100, Ard Biesheuvel wrote:
> On Mon, 3 Nov 2025 at 11:15, Francesco Pompò <francescopompo2@gmail.com> wrote:
> >
> > Il giorno lun 3 nov 2025 alle ore 09:19 Ard Biesheuvel
> > <ardb@kernel.org> ha scritto:
> > >
> > > Hello Francesco,
> > >
> > > On Sun, 2 Nov 2025 at 01:14, Francesco Pompo <francescopompo2@gmail.com> wrote:
> > > >
> > > > Some UEFI firmware implementations do not provide the SMBIOS Protocol,
> > > > causing efi_get_smbios_record() to fail. This prevents retrieval of
> > > > system information such as product name, which is needed by
> > > > apple_set_os() to enable the integrated GPU on dual-graphics Intel
> > > > MacBooks.
> > > >
> > > > Add a fallback that directly parses the SMBIOS entry point table when
> > > > the protocol is unavailable. Log when the fallback is used.
> > > >
> > > > Signed-off-by: Francesco Pompo <francescopompo2@gmail.com>
> > > > ---
> > > >  drivers/firmware/efi/libstub/efistub.h | 17 +++++
> > > >  drivers/firmware/efi/libstub/smbios.c  | 99 +++++++++++++++++++++++++-
> > > >  2 files changed, 113 insertions(+), 3 deletions(-)
> > > >
> > >
> > > On which platform does this fix an actual existing issue?
> >
> > Hello Ard,
> >
> > My Macbook Pro Late 2013, product name Macbook11,3 is affected.
> 
> You meant MacbookPro11,3, right?

Yes sorry. Anyway I sent a PATCH v2 email.

-- 
Francesco Pompo'

  reply	other threads:[~2025-11-03 13:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-02  0:13 [PATCH] efistub/smbios: Add fallback for SMBIOS record lookup Francesco Pompo
2025-11-03  8:19 ` Ard Biesheuvel
2025-11-03 10:14   ` Francesco Pompò
2025-11-03 10:41     ` Ard Biesheuvel
2025-11-03 13:11     ` Ard Biesheuvel
2025-11-03 13:14       ` francesco [this message]
2025-11-06 13:08 ` Dan Carpenter
2025-11-06 17:50   ` Ard Biesheuvel
2025-11-06 22:58     ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQiqw1kX8br_KBnT@workstation \
    --to=francescopompo2@gmail.com \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).