From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1411527FD4A; Wed, 28 Jan 2026 15:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615349; cv=none; b=PzUGOU9jO3tpoQ9GWJKYZPj3DE6wQBu/H94wl3sEaSxzkoVGm78EJlvNpw4B7dgMYCX2YGiOA6yh630vREayvHzqsLxHZSA6khrhYN1C8aVT09FKk6CJUkPyvcFClYv8tFvAxPXnhBdGDMG5ktjlST0wcRVhJ45inJSDNua9Ujs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615349; c=relaxed/simple; bh=6wFMmklklFAPh50VcRnqjsFDiX8pZAYIm93ZVHrRGaU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=O302fRq6f5GFyLnIxzQZyQ/0/TJqF/vXmx0xMn0U2Wtl1xC/csj+gTLijiS3g23kyHZMbJR6GVz1XZttjjwENNlDqZEFKfGIqRITioaKYEKf9k4Tc9uKcRjtIyox49MQHZwkJcZqBa4I3O3hHxvBg/8sT9WsbCeZi6JweYOXtCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 4EE732009D17; Wed, 28 Jan 2026 16:49:05 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 3BA7E32CA5; Wed, 28 Jan 2026 16:49:05 +0100 (CET) Date: Wed, 28 Jan 2026 16:49:05 +0100 From: Lukas Wunner To: Atharva Tiwari Cc: Ard Biesheuvel , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Thomas Zimmermann , Javier Martinez Canillas , "Borislav Petkov (AMD)" , Lenny Szubowicz , Francesco Pompo , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's Message-ID: References: <20260128145855.1071-1-atharvatiwarilinuxdev@gmail.com> <20260128145855.1071-3-atharvatiwarilinuxdev@gmail.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128145855.1071-3-atharvatiwarilinuxdev@gmail.com> On Wed, Jan 28, 2026 at 02:58:38PM +0000, Atharva Tiwari wrote: > Disable display on iMacs, as they can't do link training > on the internal display. > > (tested on iMac20,1) So with your patch the screen is black on those iMacs? I don't quite understand why that would be desirable. What happens without this patch? Something worse than a black screen? This needs to be explained in the commit message so that reviewers understand why the patch is needed. I also don't understand why this patch follows the EFI set_os one. What's the connection between those two patches? If there is none, they shouldn't be submitted as a series but as two individual patches. Thanks, Lukas