From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2B93806D9;
	Thu, 29 Jan 2026 10:33:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769682787; cv=none; b=sMuO2P8XRxFMdqe0zG8UcZQCSd/tl88C2QDKN/uW7EEu+/wBBkZHHtfnItTET4FUGh+bEn5fKs7P96hRpZeCgT+lOm6DsSrrD1U5m9ihkD/vIoBuAA2/bJkG10BWkaFBkh9d2zBa1VDbum3GIHnocWycTe4ugk4HQhbO5eXFlB0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769682787; c=relaxed/simple;
	bh=OV2dHJPpQfTJN1W0QqKp4NkTBWghhHfAKDa4pz0VoAY=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=XGPnltenLiIaUmbQHIsLn2Uri4fHgpwOMKDhLiNSjc3J5uEqc6uNvIAhDa7Z/RXn3LgJOPR4SZVA2oVz2NDSiLBQD9VK5hC4X90ucW0ZAGigoOKHc+1C4d2CDf2FsRlfcFuh1EK7Ow2aEVcn0u/DNFI+Z3yAwOdFbiBkmp0jzIw=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net
Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384
	 client-signature ECDSA (secp384r1) client-digest SHA384)
	(Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK))
	by bmailout1.hostsharing.net (Postfix) with ESMTPS id 6712B2C06849;
	Thu, 29 Jan 2026 11:33:00 +0100 (CET)
Received: by h08.hostsharing.net (Postfix, from userid 100393)
	id 5E92C2639F; Thu, 29 Jan 2026 11:33:00 +0100 (CET)
Date: Thu, 29 Jan 2026 11:33:00 +0100
From: Lukas Wunner <lukas@wunner.de>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: airlied@gmail.com, ardb@kernel.org, bp@alien8.de,
	dri-devel@lists.freedesktop.org, francescopompo2@gmail.com,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	jani.nikula@linux.intel.com, javierm@redhat.com,
	joonas.lahtinen@linux.intel.com, linux-efi@vger.kernel.org,
	linux-kernel@vger.kernel.org, lszubowi@redhat.com,
	rodrigo.vivi@intel.com, simona@ffwll.ch, tursulin@ursulin.net,
	tzimmermann@suse.de
Subject: Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple
 devices
Message-ID: <aXs3XOYucVna8eGH@wunner.de>
References: <aXovFQsk-w90wZi1@wunner.de>
 <20260129043759.1220-1-atharvatiwarilinuxdev@gmail.com>
Precedence: bulk
X-Mailing-List: linux-efi@vger.kernel.org
List-Id: <linux-efi.vger.kernel.org>
List-Subscribe: <mailto:linux-efi+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-efi+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260129043759.1220-1-atharvatiwarilinuxdev@gmail.com>

On Thu, Jan 29, 2026 at 04:37:59AM +0000, Atharva Tiwari wrote:
> > As discussed previously, your patch will regress older MacBook Airs
> > which use SPI to access keyboard + trackpad if the set_os protocol
> > is invoked:
> > 
> > https://lore.kernel.org/all/ZoJPgSlZJ3ZlU2zL@wunner.de/
> > 
> > The last time this topic came up, I suggested counting the number of
> > GPUs instead of using the DMI quirk.  I even provided a patch but
> > nobody with an eGPU bothered to test it, so the thread fizzled out:
> > 
> > https://lore.kernel.org/all/Z6paeFrjdv7L3mtv@wunner.de/
> > 
> > Maybe you could give it a spin and verify if it fixes the issue for you?
> 
> I tested your patch, and well it works (you still need the 2nd patch to 
> avoid a blank screen), but i can see how this will fail
> like for example, with the iMacPro (only has dGPU) you would need 2 eGPUs
> to turn on apple-set-os.

I don't quite follow.  The patch counts the number of GPUs and
uses the set_os protocol if there are at least 2 of them.
One dGPU + one eGPU = 2, so the protocol is used.

Am I missing something?

Thanks,

Lukas