Re: [PATCH v2 2/5] x86/efi: Gather initial memory reservation and table handling logic

Breno Leitao
2026-04-01T14:49:12Z

On Wed, Apr 01, 2026 at 02:23:54PM +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Move the back-to-back calls to various EFI routines related to
> processing of firmware tables and reserving the associated memory into a
> helper function. This is tidier, and will avoid the need to add yet
> another function call there in a subsequent patch.
>
> Reviewed-by: Gregory Price <gourry@gourry.net>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Reviewed-by: Breno Leitao <leitao@debian.org>

> +void efi_init_reservations(void);

Do you neeed __init here, as the declaration below? I know that "extern" is not
necessary, but isn't __init?

extern int __init efi_memmap_alloc(unsigned int num_entries,
struct efi_memory_map_data *data);

extern int __init efi_memmap_install(struct efi_memory_map_data *data);
extern int __init efi_memmap_split_count(efi_memory_desc_t *md,