From: Thomas Gleixner <tglx@linutronix.de>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, matthew.garrett@nebula.com,
linux-efi@vger.kernel.org, Kees Cook <keescook@chromium.org>,
gnomes@lxorguk.ukuu.org.uk, gregkh@linuxfoundation.org,
x86@kernel.org, linux-security-module@vger.kernel.org,
keyrings@vger.kernel.org
Subject: Re: [PATCH 14/24] x86: Restrict MSR access when the kernel is locked down
Date: Fri, 14 Apr 2017 20:30:33 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704142028440.2327@nanos> (raw)
In-Reply-To: <149142339340.5101.1283602261267937893.stgit@warthog.procyon.org.uk>
On Wed, 5 Apr 2017, David Howells wrote:
Can you please change the subsys in $subject to 'x86/msr:' ?
> From: Matthew Garrett <matthew.garrett@nebula.com>
>
> Writing to MSRs should not be allowed if the kernel is locked down, since
> it could lead to execution of arbitrary code in kernel mode. Based on a
> patch by Kees Cook.
>
> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Acked-by: Kees Cook <keescook@chromium.org>
> cc: x86@kernel.org
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2017-04-14 18:30 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 20:14 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 20:14 ` [PATCH 01/24] efi: Add EFI_SECURE_BOOT bit David Howells
2017-04-06 8:26 ` Ard Biesheuvel
2017-04-06 8:48 ` David Howells
[not found] ` <149142326734.5101.4596394505987813763.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 20:14 ` [PATCH 02/24] Add the ability to lock down access to the running kernel image David Howells
2017-04-05 20:15 ` [PATCH 09/24] kexec_file: Disable at runtime if securelevel has been set David Howells
[not found] ` <149142335441.5101.2294976563846442575.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07 3:05 ` Dave Young
2017-04-07 3:49 ` Mimi Zohar
[not found] ` <1491536950.4184.10.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-07 6:19 ` Dave Young
2017-04-07 7:07 ` David Howells
[not found] ` <21418.1491548875-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07 7:41 ` Dave Young
[not found] ` <20170407074159.GB10737-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-04-07 8:28 ` Mimi Zohar
[not found] ` <1491553688.4184.73.camel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-04-07 8:42 ` Dave Young
2017-04-07 7:45 ` Mimi Zohar
2017-04-07 8:01 ` Dave Young
2017-04-07 7:09 ` David Howells
2017-04-07 7:46 ` Mimi Zohar
2017-04-07 9:17 ` David Howells
2017-04-07 12:36 ` Mimi Zohar
2017-04-10 13:19 ` David Howells
[not found] ` <13679.1491830392-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-02 19:01 ` Mimi Zohar
2017-04-05 20:16 ` [PATCH 13/24] x86: Lock down IO port access when the kernel is locked down David Howells
[not found] ` <149142338597.5101.14728426552744019377.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-14 18:28 ` Thomas Gleixner
2017-04-05 20:17 ` [PATCH 22/24] Prohibit PCMCIA CIS storage " David Howells
2017-04-05 20:17 ` [PATCH 23/24] Lock down TIOCSSERIAL David Howells
2017-04-05 20:18 ` [PATCH 24/24] Lock down module params that specify hardware parameters (eg. ioport) David Howells
2017-04-05 20:14 ` [PATCH 03/24] efi: Lock down the kernel if booted in secure boot mode David Howells
2017-04-05 20:15 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 20:15 ` [PATCH 05/24] Restrict /dev/mem and /dev/kmem when " David Howells
2017-04-05 20:15 ` [PATCH 06/24] Add a sysrq option to exit secure boot mode David Howells
[not found] ` <149142332458.5101.14654616837280513947.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-14 18:05 ` Thomas Gleixner
2017-04-14 18:15 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-FDzdqACyr_z6Zsgb51mg8Lc0YgfLs4oGURWnX4WewSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-14 23:16 ` David Howells
2017-04-16 20:46 ` Matt Fleming
2017-04-05 20:15 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
[not found] ` <149142333752.5101.12956279967668146884.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-07 3:07 ` Dave Young
2017-04-05 20:15 ` [PATCH 08/24] Copy secure_boot flag in boot params across kexec reboot David Howells
2017-04-05 20:16 ` [PATCH 10/24] hibernate: Disable when the kernel is locked down David Howells
2017-04-05 20:16 ` [PATCH 11/24] uswsusp: " David Howells
[not found] ` <149142336965.5101.2946578135980499557.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 23:38 ` Rafael J. Wysocki
2017-04-06 6:39 ` Oliver Neukum
2017-04-06 8:41 ` David Howells
[not found] ` <14980.1491468060-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-06 20:09 ` Rafael J. Wysocki
2017-04-06 20:12 ` Rafael J. Wysocki
2017-04-06 20:25 ` Jiri Kosina
2017-04-08 3:28 ` poma
2017-04-12 13:44 ` joeyli
2017-04-06 6:55 ` David Howells
2017-04-06 20:07 ` Rafael J. Wysocki
2017-04-05 20:16 ` [PATCH 12/24] PCI: Lock down BAR access " David Howells
[not found] ` <149142337836.5101.13971561682218232219.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18 17:50 ` Bjorn Helgaas
2017-04-05 20:16 ` [PATCH 14/24] x86: Restrict MSR " David Howells
2017-04-14 18:30 ` Thomas Gleixner [this message]
2017-04-05 20:16 ` [PATCH 15/24] asus-wmi: Restrict debugfs interface " David Howells
2017-04-07 10:25 ` Andy Shevchenko
2017-04-07 12:50 ` David Howells
2017-04-09 11:10 ` Andy Shevchenko
2017-04-10 13:16 ` David Howells
[not found] ` <13615.1491830208-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18 6:06 ` Andy Shevchenko
2017-04-18 14:34 ` Ben Hutchings
2017-04-18 15:30 ` David Howells
[not found] ` <16503.1492529434-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-18 17:39 ` Ben Hutchings
[not found] ` <1492526075.2409.140.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-04-18 14:55 ` David Howells
2017-04-18 15:19 ` Ben Hutchings
[not found] ` <1492528799.2409.145.camel-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2017-04-18 15:34 ` David Howells
2017-04-05 20:16 ` [PATCH 16/24] ACPI: Limit access to custom_method " David Howells
2017-04-05 20:16 ` [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been " David Howells
2017-04-06 19:43 ` Rafael J. Wysocki
2017-04-07 6:31 ` Dave Young
[not found] ` <20170407063107.GA10451-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-04-07 7:05 ` David Howells
2017-04-07 7:39 ` Dave Young
2017-04-05 20:17 ` [PATCH 18/24] acpi: Disable ACPI table override if the kernel is " David Howells
2017-04-05 20:17 ` [PATCH 19/24] acpi: Disable APEI error injection " David Howells
2017-04-05 20:17 ` [PATCH 20/24] bpf: Restrict kernel image access functions when " David Howells
2017-04-06 12:29 ` Alexei Starovoitov
2017-04-06 12:40 ` Ard Biesheuvel
2017-04-13 8:46 ` David Howells
[not found] ` <149142344547.5101.4518618716303032193.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-12 14:57 ` joeyli
2017-04-05 20:17 ` [PATCH 21/24] scsi: Lock down the eata driver David Howells
2017-04-07 15:59 ` [PATCH 00/24] Kernel lockdown Austin S. Hemmelgarn
[not found] ` <25acabf2-ac99-3c2b-ee9a-53d71b5c77f2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-07 16:29 ` Justin Forbes
2017-04-10 23:15 ` Why kernel lockdown? David Howells
-- strict thread matches above, loose matches on Subject: below --
2017-04-05 17:09 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 17:12 ` [PATCH 14/24] x86: Restrict MSR access when the kernel is locked down David Howells
[not found] ` <149141232449.31282.15045536717220570492.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-04-05 17:34 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704142028440.2327@nanos \
--to=tglx@linutronix.de \
--cc=dhowells@redhat.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox