Linux EFI development
 help / color / mirror / Atom feed
From: Anisse Astier <anisse@astier.eu>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, x86@kernel.org,
	stable@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH] efivarfs: Rate limit statfs() handler
Date: Wed, 19 Aug 2026 18:29:35 +0200	[thread overview]
Message-ID: <aoXZ7xBT546YKdOY@kanto> (raw)
In-Reply-To: <20260818141150.905336-1-ardb@kernel.org>

Hi Ard,

I like the new approach, it's much simpler and easier to understand

On Tue, Aug 18, 2026 at 04:11:50PM +0200, Ard Biesheuvel wrote:
> Ravi reports that statfs() may be called by unprivileged users on the
> efivarfs mount point, which may result in a flood of calls to the
> QueryVariableInfo() runtime service. These calls are disproportionately
> costly on x86 systems where the variable store is backed by SMM, as each
> SMM entry requires a rendez-vous of all the CPUs.
> 
> So rate limit the calls to QueryVariableInfo() at twice per second, and

It's already a high-rate in performance sensitive environment. I'd have
gone higher at once per 10 seconds for example. But really, this is
minor, so please consider this:

Reviewed-by: <anisse@astier.eu>

Regards,

Anisse

  reply	other threads:[~2026-08-19 16:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 14:11 [PATCH] efivarfs: Rate limit statfs() handler Ard Biesheuvel
2026-08-19 16:29 ` Anisse Astier [this message]
2026-08-19 16:36   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoXZ7xBT546YKdOY@kanto \
    --to=anisse@astier.eu \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=ravi.bangoria@amd.com \
    --cc=stable@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox