From: Breno Leitao <leitao@debian.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: linux-efi@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] efi/runtime-wrappers: Don't park the worker after a recovered firmware fault
Date: Fri, 9 Oct 2026 08:56:02 -0700 [thread overview]
Message-ID: <askOeRkTQRw7SslG@gmail.com> (raw)
In-Reply-To: <20261009144814.338052-2-ardb+git@google.com>
On Fri, Oct 09, 2026 at 04:48:15PM +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Commit 4b2c033b5bc9 ("efi/runtime-wrappers: retire the worker if a wedged
> call ever returns") parks the efi_rts_wq worker instead of completing the
> call if EFI runtime services have been disabled by the time the firmware
> returns. The assumption is that this only happens if __efi_queue_work()
> has given up waiting for the call.
>
> However, arm64 also disables EFI runtime services when it recovers from a
> synchronous exception taken by the firmware: efi_runtime_fixup_exception()
> clears EFI_RUNTIME_SERVICES and unwinds the call so that it returns
> EFI_ABORTED to efi_call_rts(), while the caller is still waiting for the
> completion. The worker now parks without signalling it, so the caller is
> stuck for the full EFI_RTS_TIMEOUT of 120 seconds, after which it reports
> that the firmware is wedged, which is misleading.
>
> x86 is not affected, as it signals the completion from its page fault
> handler before parking the worker.
>
> So record explicitly that the caller has given up on the call, and only
> park the worker in that case.
>
> Fixes: 4b2c033b5bc9 ("efi/runtime-wrappers: retire the worker if a wedged call ever returns")
> Cc: Breno Leitao <leitao@debian.org>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
prev parent reply other threads:[~2026-10-09 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:48 [PATCH] efi/runtime-wrappers: Don't park the worker after a recovered firmware fault Ard Biesheuvel
2026-10-09 15:56 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=askOeRkTQRw7SslG@gmail.com \
--to=leitao@debian.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox