From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pv50p00im-ztdg10021201.me.com (pv50p00im-ztdg10021201.me.com [17.58.6.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83711B85FD for ; Tue, 24 Dec 2024 12:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=17.58.6.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735043827; cv=none; b=lsAdIq2iyb24WHwEN2D/XPqnNwT6oxwKKGv3ZYVXw9oSAukMZVJF3KNPVd5SY35ccbLrA78g5k7KJdcZ1uL9EQVdT1GLWIYCnRxCQ6D4jEoVca9oazau154ZyMZhvDXAxCdIEL9MKzi1nKK90MV81G5wccEjRDdsFYZBaytBlQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735043827; c=relaxed/simple; bh=Y2aWjrUlygVLOASMCiCstQK+MExRxhb4eTy19Yziwd8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tue2QpIslsrUKA1gD6Zz4wtGbHF2oW7VqBKeMHok8vfcPQUVjP038cC7OeHhnKiuXZEoipz4XhQnf2arDQvLg/9tYFRdihAch7Lvey+B/CwzRpugSzUMFu5iOZ+bS8Bbzuu6Ft7hmDJYTZHxIP4Pr08Ks8q7aZ1URwLzGQnvOaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=NFw8nGV4; arc=none smtp.client-ip=17.58.6.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="NFw8nGV4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1735043825; bh=Gc2WCxVDa+xL90LnfPEoTmxwnPsFBGQJFu6/HAU7lKY=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: x-icloud-hme; b=NFw8nGV4mMSulnri61yzK+qJGcy9/Ch+dsuJHrKfVwVsiimtCnAG3h8rFHRxp+Uyz upQRA6wkcAq6UoCdHY35JVRQ8fAMwi0fFRWx45ifLIDKIpYYNfnCXbGxhfEOaQYXsR 1vp17v6CL5aedV5Ya9jk+HyrT7k0UWB64khbCMphdv/pxVqrNG01HpV70G71hkXLci t2DsBn5eAui7bmqHM/lylU/XqVzY8Fkjio57aPrnWpZ6YDIPQmlxL9eysloKkBj+Wn CHNdKt4EUe+nfzoaAy+0w9w20JbbblWFRe+AQzyMxBHNEYMWVIIso0RplKSOHi0f8w fzQi63k6MyURg== Received: from [192.168.1.25] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10021201.me.com (Postfix) with ESMTPSA id 14C393118B4A; Tue, 24 Dec 2024 12:36:26 +0000 (UTC) Message-ID: Date: Tue, 24 Dec 2024 20:36:04 +0800 Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/11] bus: fsl-mc: Constify fsl_mc_device_match() To: Jonathan Cameron Cc: Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , James Bottomley , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-sound@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, linux-cxl@vger.kernel.org, linux1394-devel@lists.sourceforge.net, arm-scmi@vger.kernel.org, linux-efi@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, Zijun Hu References: <20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com> <20241211-const_dfc_done-v4-3-583cc60329df@quicinc.com> <20241223202635.00005a0a@huawei.com> Content-Language: en-US From: Zijun Hu In-Reply-To: <20241223202635.00005a0a@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2024/12/24 04:26, Jonathan Cameron wrote: > On Wed, 11 Dec 2024 08:08:05 +0800 > Zijun Hu wrote: > >> From: Zijun Hu >> >> fsl_mc_device_match() does not modify caller's inputs. >> >> Constify it by simply changing its parameter types to const pointer. >> >> Signed-off-by: Zijun Hu > Similar to previous patch, I'd say why you are making this change. > There are may places in the kernel where pointers are constant but > not marked so. Why does this one matter? > thank you for code review. make sense. will correct comment message for this and previous patch in v5. > With that info added > Reviewed-by: Jonathan Cameron