From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
To: Dan Williams <dan.j.williams@intel.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Bowman Terry <terry.bowman@amd.com>
Subject: Re: [PATCH v2 2/4] cxl/pci: Define a common function get_cxl_devstate()
Date: Thu, 3 Oct 2024 11:44:16 -0700 [thread overview]
Message-ID: <bca60d5d-a395-9733-5aed-b83bc924cbe6@amd.com> (raw)
In-Reply-To: <66fdd178bced1_964f229451@dwillia2-xfh.jf.intel.com.notmuch>
On 10/2/2024 4:04 PM, Dan Williams wrote:
> Smita Koralahalli wrote:
>> Refactor computation of cxlds to a common function get_cxl_devstate().
>>
>> The above function could then be reused in both FW-First Component and
>> Protocol error reporting and handling.
>
> Ira caught the bug in the cleanup conversion, but I am otherwise not
> convinced there would be much reuse for a helper like this given any
> endpoint-flagged protocol errors would reuse the common
> cxl_handle_cper_event(), unless I am missing something?
>
Yeah, the only intent was to not redo the BDF decoding at two places. I
don't see a problem in calling cxl_handle_prot_err() inside
cxl_handle_cper_event() as Ira suggested in 4/4.
However, I think all of this would fall off if we isolate protocol
errors from cxl_cper_fifo and handle them separately.
Thanks
Smita
next prev parent reply other threads:[~2024-10-03 18:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 0:52 [PATCH v2 0/4] acpi/ghes, cper, cxl: Trace FW-First CXL Protocol Errors Smita Koralahalli
2024-10-01 0:52 ` [PATCH v2 1/4] efi/cper, cxl: Make definitions and structures global Smita Koralahalli
2024-10-02 23:02 ` Dan Williams
2024-10-03 8:51 ` Ard Biesheuvel
2024-10-01 0:52 ` [PATCH v2 2/4] cxl/pci: Define a common function get_cxl_devstate() Smita Koralahalli
2024-10-01 15:06 ` Ira Weiny
2024-10-02 23:04 ` Dan Williams
2024-10-03 18:44 ` Smita Koralahalli [this message]
2024-10-01 0:52 ` [PATCH v2 3/4] acpi/ghes, efi/cper: Recognize and process CXL Protocol Errors Smita Koralahalli
2024-10-01 15:47 ` Ira Weiny
2024-10-01 17:41 ` Fan Ni
2024-10-03 19:19 ` Smita Koralahalli
2024-10-02 23:47 ` Dan Williams
2024-10-03 19:15 ` Smita Koralahalli
2024-10-03 23:21 ` Dan Williams
2024-10-01 0:52 ` [PATCH v2 4/4] acpi/ghes, cxl/pci: Trace FW-First " Smita Koralahalli
2024-10-01 15:52 ` Ira Weiny
2024-10-03 19:31 ` Smita Koralahalli
2024-10-03 0:16 ` Dan Williams
2024-10-03 20:03 ` Smita Koralahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca60d5d-a395-9733-5aed-b83bc924cbe6@amd.com \
--to=smita.koralahallichannabasappa@amd.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terry.bowman@amd.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox