Re: [PATCH v4 4/4] efi: sysfb_efi: Fix efidrmfb and simpledrmfb on Valve Steam Deck

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 05.12.25 um 16:36 schrieb Tvrtko Ursulin:
> Valve Steam Deck has a 800x1280 portrait screen installed in a landscape
> orientation. The firmware offers a software rotated 1280x800 mode which

"software-rotated"

comma before 'which'

> GRUB can be made to switch to when displaying a boot menu. If this mode
> was selected frame buffer drivers will see this fake mode and fbcon
> rendering will be corrupted.
>
> Lets therefore add a selective quirk inside the current "swap with and

"Let us" or "Let's"

> height" handling, which will detect this exact mode and fix it up back to
> the native one.
>
> This will allow the DRM based frame buffer drivers to detect the correct

"DRM-based framebuffer"

> mode and, apply the existing panel orientation quirk, and render the

No 'and' after mode

> console in landscape mode with no corruption.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Melissa Wen <mwen@igalia.com>
> Cc: linux-efi@vger.kernel.org
> Tested-by: Melissa Wen <mwen@igalia.com> # v3

With typos fixed:

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for fixing this.

Best regards
Thomas

> ---
>   drivers/firmware/efi/sysfb_efi.c | 47 ++++++++++++++++++++++++++++++++
>   1 file changed, 47 insertions(+)
>
> diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
> index 5c54f42d5fef..db28e11d1eb7 100644
> --- a/drivers/firmware/efi/sysfb_efi.c
> +++ b/drivers/firmware/efi/sysfb_efi.c
> @@ -242,6 +242,33 @@ static int __init efifb_swap_width_height(const struct dmi_system_id *id)
>   	return 1;
>   }
>   
> +struct efifb_mode_fixup {
> +	unsigned int width;
> +	unsigned int height;
> +	unsigned int linelength;
> +};
> +
> +static int __init
> +efifb_check_and_swap_width_height(const struct dmi_system_id *id)
> +{
> +	const struct efifb_mode_fixup *data = id->driver_data;
> +
> +	if (data->width == screen_info.lfb_width &&
> +	    data->height == screen_info.lfb_height) {
> +		swap(screen_info.lfb_width, screen_info.lfb_height);
> +		screen_info.lfb_linelength = data->linelength;
> +		screen_info.lfb_size = data->linelength * data->width;
> +	}
> +
> +	return 1;
> +}
> +
> +static const struct efifb_mode_fixup efifb_steamdeck_mode_fixup __initconst = {
> +	.width = 1280,
> +	.height = 800,
> +	.linelength = 3328,
> +};
> +
>   /*
>    * Some devices have a portrait LCD but advertise a landscape resolution (and
>    * pitch). We simply swap width and height for these devices so that we can
> @@ -297,6 +324,26 @@ static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
>   		},
>   		.callback = efifb_swap_width_height,
>   	},
> +	{
> +		/* Valve Steam Deck (Jupiter) */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.callback = efifb_check_and_swap_width_height,
> +		.driver_data = (void *)&efifb_steamdeck_mode_fixup,
> +	},
> +	{
> +		/* Valve Steam Deck (Galileo) */
> +		.matches = {
> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.callback = efifb_check_and_swap_width_height,
> +		.driver_data = (void *)&efifb_steamdeck_mode_fixup,
> +	},
>   	{},
>   };
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)