From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72AD0C43334 for ; Fri, 10 Jun 2022 09:29:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348937AbiFJJ3v (ORCPT ); Fri, 10 Jun 2022 05:29:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348962AbiFJJ31 (ORCPT ); Fri, 10 Jun 2022 05:29:27 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F88A2E698; Fri, 10 Jun 2022 02:27:35 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LKFsH4cZSzRhQJ; Fri, 10 Jun 2022 17:24:19 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 17:27:33 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 17:27:32 +0800 Message-ID: Date: Fri, 10 Jun 2022 17:27:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges Content-Language: en-US To: Wupeng Ma , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220607093805.1354256-1-mawupeng1@huawei.com> <20220607093805.1354256-3-mawupeng1@huawei.com> From: Kefeng Wang In-Reply-To: <20220607093805.1354256-3-mawupeng1@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On 2022/6/7 17:38, Wupeng Ma wrote: > From: Ma Wupeng > > Commit b05b9f5f9dcf ("x86, mirror: x86 enabling - find mirrored memory ranges") > introduced mirrored memory support for x86 and this could be used on arm64. > > Since we only support this feature on arm64, efi_find_mirror() won't be placed > into efi_init(), which is used by riscv/arm/arm64, it is added in setup_arch() > to scan the memory map and mark mirrored memory in memblock. Move into efi_init() looks better, it won't bring negative effects on arm/riscv. but let's maintainer to make a decision. Reviewed-by: Kefeng Wang > > Signed-off-by: Ma Wupeng > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > arch/arm64/kernel/setup.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > index 8090130b544b..e3537646b6f7 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -2301,7 +2301,7 @@ > > keepinitrd [HW,ARM] > > - kernelcore= [KNL,X86,IA-64,PPC] > + kernelcore= [KNL,X86,IA-64,PPC,ARM64] > Format: nn[KMGTPE] | nn% | "mirror" > This parameter specifies the amount of memory usable by > the kernel for non-movable allocations. The requested > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index cf3a759f10d4..6e9acd7ecf0f 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -328,6 +328,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p) > > xen_early_init(); > efi_init(); > + efi_find_mirror(); > > if (!efi_enabled(EFI_BOOT) && ((u64)_text % MIN_KIMG_ALIGN) != 0) > pr_warn(FW_BUG "Kernel image misaligned at boot, please fix your bootloader!");