Re: [PATCH v2 6/6] efivarfs: fix error on write to new variable leaving remnants

Al Viro
2025-01-16T18:45:19Z

On Mon, Jan 06, 2025 at 06:35:25PM -0800, James Bottomley wrote:

> + inode_lock(inode);
> + if (d_unhashed(file->f_path.dentry)) {
> + /*
> + * file got removed; don't allow a set. Caused by an
> + * unsuccessful create or successful delete write
> + * racing with us.
> + */
> + bytes = -EIO;
> + goto out;
> + }

Wouldn't the check for zero ->i_size work here? Would be easier to
follow...