From: Jiri Slaby <jirislaby@kernel.org>
To: Gregory Price <gourry@gourry.net>, Usama Arif <usamaarif642@gmail.com>
Cc: Ard Biesheuvel <ardb+git@google.com>,
linux-efi@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
stable@vger.kernel.org, Breno Leitao <leitao@debian.org>
Subject: Re: [PATCH] efistub/tpm: Use ACPI reclaim memory for event log to avoid corruption
Date: Thu, 31 Oct 2024 09:19:28 +0100 [thread overview]
Message-ID: <c7ec5844-93b8-4603-a12d-a19d9c22a685@kernel.org> (raw)
In-Reply-To: <ZyJ6QHc9FetDckqo@PC2K9PVX.TheFacebook.com>
On 30. 10. 24, 19:26, Gregory Price wrote:
> you may also want to investigate this patch set:
>
> https://lore.kernel.org/all/20240913231954.20081-1-gourry@gourry.net/
>
> which I believe would have caught your "eat all memory" sign extention issue.
But it's memattr what is corrupted, not tpmeventlog.
The reporter is using this for some time and it indeed works:
--- a/drivers/firmware/efi/memattr.c
+++ b/drivers/firmware/efi/memattr.c
@@ -12,7 +12,7 @@
#include <asm/early_ioremap.h>
-static int __initdata tbl_size;
+static phys_addr_t __initdata tbl_size;
unsigned long __ro_after_init efi_mem_attr_table = EFI_INVALID_TABLE_ADDR;
/*
--
js
suse labs
prev parent reply other threads:[~2024-10-31 8:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 15:52 [PATCH] efistub/tpm: Use ACPI reclaim memory for event log to avoid corruption Ard Biesheuvel
2024-09-13 6:27 ` Ilias Apalodimas
2024-09-13 10:00 ` Breno Leitao
2024-10-24 16:20 ` Jiri Slaby
2024-10-25 5:07 ` Jiri Slaby
2024-10-25 5:09 ` Jiri Slaby
2024-10-25 7:30 ` Ard Biesheuvel
2024-10-30 16:32 ` Gregory Price
2024-10-31 7:55 ` Jiri Slaby
2024-10-31 9:04 ` Ard Biesheuvel
2024-10-25 13:27 ` Usama Arif
2024-10-30 5:25 ` Jiri Slaby
2024-10-30 17:13 ` Usama Arif
2024-10-30 18:02 ` Gregory Price
2024-10-30 18:24 ` Usama Arif
2024-10-31 8:38 ` Jiri Slaby
2024-10-30 18:26 ` Gregory Price
2024-10-30 19:43 ` Ard Biesheuvel
2024-10-30 20:30 ` Gregory Price
2024-10-31 8:19 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ec5844-93b8-4603-a12d-a19d9c22a685@kernel.org \
--to=jirislaby@kernel.org \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=gourry@gourry.net \
--cc=leitao@debian.org \
--cc=linux-efi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=usamaarif642@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox